Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prevent duplicated subscribers creation #247

Merged
merged 3 commits into from Dec 14, 2023

Conversation

patriciareinoso
Copy link
Contributor

@patriciareinoso patriciareinoso commented Dec 12, 2023

Description

We now validate whether a subscriber with the same name already exists before creating it. If it already exists, an error is displayed to the user in the creation modal.

image

There is an issue with the CURL GET of subscribers (omec-project/webconsole#109) in which an "empty" subscriber object is returned if the subscriber does not exists. So, as a workaround I added a check over one of the fields to be able to differentiate between a subscriber that exists and one that does not.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
@patriciareinoso patriciareinoso force-pushed the TELCO-793-prevent-duplicated-subscribers branch from 606eee9 to b183ba1 Compare December 14, 2023 10:46
@patriciareinoso patriciareinoso merged commit c74c983 into main Dec 14, 2023
8 checks passed
@patriciareinoso patriciareinoso deleted the TELCO-793-prevent-duplicated-subscribers branch December 14, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants