Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to container.exec #574

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amandahla
Copy link

Issue

For some reason, alertmanager and prometheus pods are getting constantly restarted and we couldnt figured out why.

Versions:
Juju 3.1.6
Alertmanager latest/edge 98
Prometheus latest/edge 170

Solution

I was not able to put my finger on it but this PR just adds timeout to the container.exec calls to make sure that this is not leaking and making pebble unresponsive.

Context

Pebble

Testing Instructions

No instructions. It happens randomly.

Release Notes

@sed-i
Copy link
Contributor

sed-i commented Apr 10, 2024

Thanks @amandahla and sorry for the long delay.

  • Do you still find the timeout useful?
  • Could 3 sec be too short?
  • Iiuc, a timeout would put the charm in error state. Not sure which approach is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants