-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostics tox env #472
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than leaving line-by-line comments, I'll give a generalized take:
This is nice.
The README note is probably less than clear, and something like "to fetch a summary of alert rules and metrics series present in Prometheus...", as the diagnostics may imply that it actually does some diagnostic work (rather than giving the user information which may help bisect juju data and workload-visible/rendered data) may work, but the actual verbiage is less important.
diagnostics.sh
probably doesn't belong in tests/
. Rather, some new folder which we don't have a name for. hack/
would be common in "operators", and while that's mostly used for bootstrapping the kubebuilder stuff itself, the paradigm could work here.
I feel like this type of content could have its own Regardless, I'd use the word |
How about:
|
I mean, couldn't I still don't think Arguably, the best would be to get the Juju team to extend |
It's not diagnosing anything yet :) Not sure what you mean about jujuc. Are you talking about juju plugins? |
Issue
When doing manual tests, I keep using the same lengthy commands over and over.
Solution
Add a diagnostics script to output all the interesting integration-related content.
Context
Came up in during work on canonical/grafana-agent-k8s-operator#160.
Testing Instructions
tox -e diag -- prom/0
Release Notes
Add diagnostics tox env.