[DPE-4157] Add upgrade basics #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
commented
Apr 23, 2024
| @@ -58,3 +58,14 @@ set-tls-private-key: | |||
|
|
|||
| pre-upgrade-check: | |||
| description: Run necessary pre-upgrade checks before executing a charm upgrade. | |||
|
|
|||
There was a problem hiding this comment.
copied from OpenSearch
| UPGRADE_RELATION = "upgrade" | ||
|
|
||
|
|
||
| class MongoDBUpgrade(Object): |
There was a problem hiding this comment.
most of this is copied from OpenSearch with some changes for MongoDB
carlcsaposs-canonical
requested changes
Apr 25, 2024
Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>
carlcsaposs-canonical
approved these changes
Apr 25, 2024
MiaAltieri
force-pushed
the
add-upgrade-basics
branch
from
ae32088
to
5334baa
Compare
MiaAltieri
commented
Apr 25, 2024
| from config import Config | ||
| from upgrades import upgrade |
There was a problem hiding this comment.
copied from opensearch
MiaAltieri
commented
Apr 25, 2024
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| import abc | |||
| import copy | |||
| import enum | |||
There was a problem hiding this comment.
copied from opensearch
Mehdi-Bendriss
approved these changes
Apr 29, 2024
MiaAltieri
changed the title
MiaAltieri
force-pushed
the
add-upgrade-basics
branch
from
207a582
to
3d21f1c
Compare
MiaAltieri
force-pushed
the
add-upgrade-basics
branch
from
3d6c275
to
ce3c92f
Compare
MiaAltieri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before implementing Upgrades add some of the boiler plate that is necessary for them. (i.e. Carl's event handlers + small changes for them to work with MongoDB)
Future PRs
machine_upgrades.py