Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preflight check (without app status check and move primary check) #405

Open
wants to merge 3 commits into
base: new-upgrade-implementation
Choose a base branch
from

Conversation

MiaAltieri
Copy link
Contributor

@MiaAltieri MiaAltieri commented Apr 19, 2024

Issue

There is no pre-flight check for upgrades

Solution

Copying over old-preflight check to new upgrade implementation

Summary + Future PRs

My goal is to simplify PR review and separate out:

  1. already reviewed code for pre-flight checks
  2. new code that is necessary for pre-flight checks

In order to separate out the new pre-flight checks with the old ones. I will make two PRs:

  1. This one with the old code. This code was already reviewed in the previous implementation + adding back int tests
  2. A second one with more checks such as:
  • moving the MongoDB primary
  • checking all units of juju application are active
  • some unit tests

Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Mia!

@carlcsaposs-canonical
Copy link
Contributor

apologizes for the delay; planning to review after implementing pre-upgrade-check structure in opensearch (https://warthogs.atlassian.net/browse/DPE-4128)

@MiaAltieri please let me know if you'd like me to review earlier

Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's the pre-upgrade check shared code canonical/opensearch-operator#262 (runs pre-upgrade-check on action and automatically after juju refresh before first unit upgrade)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants