-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix id: graphics/{index}_gl_support_{product_slug}
alway return ture (New)
#1247
Conversation
…rt issue as describing in #1122. The job and test plan will be addressed in another PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
+ Coverage 43.37% 43.53% +0.15%
==========================================
Files 357 358 +1
Lines 38693 38722 +29
Branches 6561 6565 +4
==========================================
+ Hits 16784 16857 +73
+ Misses 21245 21200 -45
- Partials 664 665 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
the result is correct and remove the color code at the same time.
Description
This PR is going to create a python script to fix
id: graphics/{index}_gl_support_{product_slug}
issue as describing in#1122.
The job and test plan will be addressed in another PR.
Resolved issues
The command used in
id: graphics/{index}_gl_support_{product_slug}
will always return true to make this test always pass.
Documentation
Tests
Unit test
If you would like to make the renderer to be changed to llvmpipe while testing, you could use following command to test.