Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix id: graphics/{index}_gl_support_{product_slug} alway return ture (New) #1247

Merged
merged 4 commits into from
May 30, 2024

Conversation

hanhsuan
Copy link
Contributor

Description

This PR is going to create a python script to fix id: graphics/{index}_gl_support_{product_slug} issue as describing in
#1122.

The job and test plan will be addressed in another PR.

Resolved issues

The command used in id: graphics/{index}_gl_support_{product_slug}

"$CHECKBOX_RUNTIME"/usr/lib/nux/unity_support_test -p 2>&1 | sed -e "s/\x1b\[[0-9;]*m//g"

will always return true to make this test always pass.

Documentation

Tests

Unit test

If you would like to make the renderer to be changed to llvmpipe while testing, you could use following command to test.

LIBGL_ALWAYS_SOFTWARE=1 python3 gl_support.py

…rt issue as describing in

#1122.

The job and test plan will be addressed in another PR.
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.53%. Comparing base (ba754d6) to head (36e416c).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1247      +/-   ##
==========================================
+ Coverage   43.37%   43.53%   +0.15%     
==========================================
  Files         357      358       +1     
  Lines       38693    38722      +29     
  Branches     6561     6565       +4     
==========================================
+ Hits        16784    16857      +73     
+ Misses      21245    21200      -45     
- Partials      664      665       +1     
Flag Coverage Δ
provider-base 17.21% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Hook25 Hook25 merged commit 17cc65b into main May 30, 2024
13 checks passed
@Hook25 Hook25 deleted the fix_gl_support_always_pass branch May 30, 2024 14:23
hanhsuan added a commit that referenced this pull request Jun 3, 2024
the result is correct and remove the color code at the same time.
Hook25 pushed a commit that referenced this pull request Jun 3, 2024
…(BugFix) (#1268)

This is part of #1247 and use the script that merged in it to make sure
the result is correct and remove the color code at the same time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants