Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysfs led indicator to auto coverage (New) #1233

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

rickwu666666
Copy link
Contributor

Description

Re-push this PR to prevent codecov issue. Original PR here.
Add led indicator test auto-test job and plan. Also, add it into ce-oem auto test coverage due to we have a regression issue found in the post-gm stage.

Resolved issues

Documentation

Tests

Sideload results with make up some non-existent led paths
https://certification.canonical.com/hardware/202205-30270/submission/361748/test-results/

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.36%. Comparing base (414006d) to head (e117a7f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   43.36%   43.36%           
=======================================
  Files         357      357           
  Lines       38684    38684           
  Branches     6560     6560           
=======================================
  Hits        16775    16775           
  Misses      21245    21245           
  Partials      664      664           
Flag Coverage Δ
provider-base 16.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one note, why is this called XXX-manual if it is actually automated?

EDIT: nvm the view was collapsed and I didnt see it is a completely different job. Well done! merging

@Hook25 Hook25 merged commit c894f51 into main Jun 4, 2024
13 checks passed
@Hook25 Hook25 deleted the add-sysfs-led-indicator-to-auto-coverage branch June 4, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants