Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkbox-ce-oem] Add timedatectl test in strict-confinement mode (New) #1232

Merged
merged 3 commits into from
May 29, 2024

Conversation

rickwu666666
Copy link
Contributor

@rickwu666666 rickwu666666 commented May 7, 2024

Description

Add timedatectl test for testing if timezone and NTP time sync can be configured in strict-confinement mode. This test rely on test snap.

Resolved issues

Documentation

Tests

Test result pass:
https://certification.canonical.com/hardware/202304-31486/submission/368054/

Test result failed without connect interface:
https://certification.canonical.com/hardware/202304-31486/submission/368057/

@rickwu666666 rickwu666666 changed the title [checkbox-ce-oem] Add timedatactl test in strict-confinement mode(New) [checkbox-ce-oem] Add timedatactl test in strict-confinement mode (New) May 7, 2024
@LiaoU3 LiaoU3 changed the title [checkbox-ce-oem] Add timedatactl test in strict-confinement mode (New) [checkbox-ce-oem] Add timedatectl test in strict-confinement mode(New) May 7, 2024
@LiaoU3 LiaoU3 changed the title [checkbox-ce-oem] Add timedatectl test in strict-confinement mode(New) [checkbox-ce-oem] Add timedatectl test in strict-confinement mode (New) May 7, 2024
@stanley31huang
Copy link
Collaborator

I think we need to have post-suspend for timedate control tests as well.

Another point I would like to raise here is, is the interface connection will be connected automatically? If not, the confinement related tests will be skipped.

@rickwu666666
Copy link
Contributor Author

rickwu666666 commented May 22, 2024

Another point I would like to raise here is, is the interface connection will be connected automatically? If not, the confinement related tests will be skipped.

No the interfaces connect won't be automatically. It's rely on manually or via a setup script. And yes, if the interfaces are not connected before the test, than the test will be skipped. And this is the reason which I put the requires of slot and plug.

@rickwu666666 rickwu666666 force-pushed the add_time_test_in_strict_confinement_mode branch from 7bf1465 to 2fc0e01 Compare May 22, 2024 02:40
@rickwu666666
Copy link
Contributor Author

list-bootstrapped of timedatectl:
com.canonical.certification::connections
com.canonical.certification::lsb
com.canonical.certification::snap
com.canonical.contrib::strict-confinement/timedatectl-timezone
com.canonical.certification::rtc
com.canonical.certification::sleep
com.canonical.certification::suspend/suspend_advanced_auto
com.canonical.contrib::after-suspend-strict-confinement/timedatectl-timezone
com.canonical.contrib::strict-confinement/timedatectl-ntp
com.canonical.contrib::after-suspend-strict-confinement/timedatectl-ntp

list-bootstrapped of mediacare:
com.canonical.certification::lsb
com.canonical.plainbox::manifest
com.canonical.certification::snap
com.canonical.contrib::strict-confine/mediacard/sdhc-insert
com.canonical.certification::sleep
com.canonical.certification::rtc
com.canonical.certification::suspend/suspend_advanced_auto
com.canonical.contrib::after-suspend-strict-confine/mediacard/sdhc-insert
com.canonical.contrib::strict-confine/mediacard/sdhc-storage
com.canonical.contrib::after-suspend-strict-confine/mediacard/sdhc-storage
com.canonical.contrib::strict-confine/mediacard/sdhc-remove
com.canonical.contrib::after-suspend-strict-confine/mediacard/sdhc-remove

@rickwu666666
Copy link
Contributor Author

@stanley31huang
I've pushed the update to add post suspend parts. Thanks for the review.

@stanley31huang
Copy link
Collaborator

LGTM for now, but I would like to separate those jobs and test plans into following structure and also consistent naming rule.

root -> units -> test_plans.pxu
                    -> jobs.pxu

Copy link
Collaborator

@stanley31huang stanley31huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need another PR to structure the test plan and job.

@rickwu666666 rickwu666666 merged commit f6fc337 into main May 29, 2024
6 checks passed
@rickwu666666 rickwu666666 deleted the add_time_test_in_strict_confinement_mode branch May 29, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants