Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkbox-ce-oem] Modify tcpecho_stress script (Bugfix) #1219

Merged
merged 4 commits into from
May 29, 2024

Conversation

rickwu666666
Copy link
Contributor

@rickwu666666 rickwu666666 commented Apr 30, 2024

To prevent parent eth of ethernet switch been disable

Description

Add condition to not disable parent interface for test multi-ports switch.
e.g. We have a platform which have 7-ports switch as follows. As it shows, eth0 is the parent interface of lan1 to lan6. In this case, we can not disable eth0 if we are intend to test lan1 to lan6.

beats@ubuntu:~$ ip -c a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host 
       valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1502 qdisc mq state UP group default qlen 1000
    link/ether 52:28:41:56:75:47 brd ff:ff:ff:ff:ff:ff
    inet6 fe80::5028:41ff:fe56:7547/64 scope link 
       valid_lft forever preferred_lft forever
3: mstp1: <BROADCAST,NOARP> mtu 1497 qdisc noop state DOWN group default qlen 10
    link/[261] 78 brd ff
4: mstp2: <BROADCAST,NOARP> mtu 1497 qdisc noop state DOWN group default qlen 10
    link/[261] 78 brd ff
5: lan1@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
    link/ether 52:28:41:56:75:47 brd ff:ff:ff:ff:ff:ff
    inet 10.102.89.216/23 brd 10.102.89.255 scope global dynamic lan1
       valid_lft 376sec preferred_lft 376sec
    inet6 fe80::5028:41ff:fe56:7547/64 scope link 
       valid_lft forever preferred_lft forever
6: lan2@eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state LOWERLAYERDOWN group default qlen 1000
    link/ether 52:28:41:56:75:47 brd ff:ff:ff:ff:ff:ff
    inet6 fe80::5028:41ff:fe56:7547/64 scope link 
       valid_lft forever preferred_lft forever
7: lan3@eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 52:28:41:56:75:47 brd ff:ff:ff:ff:ff:ff
8: lan4@eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 52:28:41:56:75:47 brd ff:ff:ff:ff:ff:ff
9: lan5@eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 52:28:41:56:75:47 brd ff:ff:ff:ff:ff:ff
10: lan6@eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 52:28:41:56:75:47 brd ff:ff:ff:ff:ff:ff

Resolved issues

Documentation

Tests

Test result: https://certification.canonical.com/hardware/202402-33505/submission/366205/test-results/pass/

@rickwu666666 rickwu666666 changed the title Modify tcpecho_stress script [checkbox-ce-oem] Modify tcpecho_stress script (Bugfix) Apr 30, 2024
@rickwu666666 rickwu666666 force-pushed the modify-tcpecho-stress-not-disable-parent-eth branch 2 times, most recently from 56d8c8d to 10d8dd3 Compare May 22, 2024 02:56
@rickwu666666
Copy link
Contributor Author

Add the comment to explain the added logic in the script.

@rickwu666666 rickwu666666 force-pushed the modify-tcpecho-stress-not-disable-parent-eth branch from 10d8dd3 to 772259d Compare May 29, 2024 01:04
@rickwu666666
Copy link
Contributor Author

Fix the typo of function name

@rickwu666666
Copy link
Contributor Author

Fix typo and wording in the script.

Copy link
Collaborator

@stanley31huang stanley31huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickwu666666 rickwu666666 merged commit ac6fdc2 into main May 29, 2024
5 checks passed
@rickwu666666 rickwu666666 deleted the modify-tcpecho-stress-not-disable-parent-eth branch May 29, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants