Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cert-blocker status based on coverage guide for IoT test plans (BugFix) #1206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pieqq
Copy link
Collaborator

@pieqq pieqq commented Apr 24, 2024

Description

The "Internet of Things Certified Hardware Coverage for Ubuntu Core 22 / Ubuntu 22.04" document specifies what jobs should be considered as blockers.

For IoT devices, the after-suspend jobs are not considered blockers, so they have been left out.

Considerations

The document I used as a "source of truth" specifies a few things that look suspicious. Feedback from other teams would be appreciated:

Resolved issues

CER-2593

Documentation

Tests

Running a list-bootstrapped of the client-cert-iot-ubuntucore-22 test plan on my laptop yields the following output:

Notes:

checkbox-cli list-bootstrapped -f "{id} [{certification_status}]\n" "com.canonical.certification::client-cert-iot-ubuntucore-22"
(...)
manifest [non-blocker]
executable [non-blocker]
interface [non-blocker]
connections [non-blocker]
model_assertion [non-blocker]
serial_assertion [non-blocker]
net_if_management [non-blocker]
net_if_management_attachment [non-blocker]
lspci_attachment [non-blocker]
lsusb_attachment [non-blocker]
rtc [non-blocker]
sleep [non-blocker]
parts_meta_info_attachment [non-blocker]
miscellanea/device_check [non-blocker]
requirements [non-blocker]
cpuinfo [non-blocker]
dpkg [non-blocker]
sysfs_attachment [non-blocker]
lspci_standard_config_json [non-blocker]
efi [non-blocker]
lsblk_attachment [non-blocker]
snap [non-blocker]
device [non-blocker]
dmi_present [non-blocker]
raw_devices_dmi_json [non-blocker]
udev_attachment [non-blocker]
lsb [non-blocker]
uname [non-blocker]
modprobe_json [non-blocker]
meminfo [non-blocker]
environment [non-blocker]
udev_json [non-blocker]
dmi [non-blocker]
kernel_cmdline_attachment [non-blocker]
dmi_attachment [non-blocker]
package [non-blocker]
module [non-blocker]
system_info_json [non-blocker]
cdimage [non-blocker]
dkms_info_json [non-blocker]
miscellanea/submission-resources [non-blocker]
info/systemd-analyze [non-blocker]
info/systemd-analyze-critical-chain [non-blocker]
ubuntucore/os-reinstall-mode [non-blocker]
ubuntucore/os-recovery-mode [non-blocker]
ubuntucore/sshd [non-blocker]
audio/detect-playback-devices [non-blocker]
audio/alsa-playback [blocker]
bluetooth/keyboard-manual [blocker]
ethernet/wol_S5_enp0s31f6 [non-blocker]
ethernet/wol_S4_enp0s31f6 [non-blocker]
ethernet/wol_S3_enp0s31f6 [non-blocker]
ethernet/hotplug-enp0s31f6 [non-blocker]
led/power [blocker]
led/power-blink-suspend [non-blocker]
led/bluetooth [non-blocker]
led/serial [blocker]
led/fn [non-blocker]
mediacard/cf-insert [non-blocker]
mediacard/cf-storage [non-blocker]
mediacard/cf-remove [non-blocker]
mediacard/mmc-insert [non-blocker]
mediacard/mmc-storage [non-blocker]
mediacard/mmc-remove [non-blocker]
mediacard/ms-insert [non-blocker]
mediacard/ms-storage [non-blocker]
mediacard/ms-remove [non-blocker]
mediacard/msp-insert [non-blocker]
mediacard/msp-storage [non-blocker]
mediacard/msp-remove [non-blocker]
mediacard/sd-insert [non-blocker]
mediacard/sd-storage [non-blocker]
mediacard/sd-remove [non-blocker]
mediacard/sdhc-insert [non-blocker]
mediacard/sdhc-storage [non-blocker]
mediacard/sdhc-remove [non-blocker]
mediacard/sdxc-insert [non-blocker]
mediacard/sdxc-storage [non-blocker]
mediacard/sdxc-remove [non-blocker]
mediacard/xd-insert [non-blocker]
mediacard/xd-storage [non-blocker]
mediacard/xd-remove [non-blocker]
monitor/dvi [blocker]
monitor/hdmi [blocker]
monitor/dvi-to-vga [non-blocker]
monitor/hdmi-to-vga [non-blocker]
monitor/displayport_hotplug [blocker]
monitor/vga [non-blocker]
rtc/battery [blocker]
serial/rs232-console [blocker]
snappy/os-refresh [non-blocker]
snappy/os-revert [non-blocker]
usb/hid [blocker]
usb/insert [blocker]
usb/storage-automated [blocker]
usb/remove [blocker]
usb-c/c-to-a-adapter/hid [non-blocker]
usb [non-blocker]
usb-c/c-to-a-adapter/insert [non-blocker]
usb-c/c-to-a-adapter/storage-automated [non-blocker]
usb-c/c-to-a-adapter/remove [non-blocker]
usb-c/hid [non-blocker]
usb-c/insert [non-blocker]
usb-c/storage-automated [non-blocker]
usb-c/remove [non-blocker]
usb-c-otg/g_serial [non-blocker]
usb-c-otg/g_serial-cleanup [non-blocker]
usb-c-otg/g_mass_storage [non-blocker]
usb-c-otg/g_mass_storage-cleanup [non-blocker]
usb-c-otg/g_ether [non-blocker]
usb-c-otg/g_ether-cleanup [non-blocker]
usb3/insert [non-blocker]
usb3/storage-automated [non-blocker]
usb3/remove [non-blocker]
thunderbolt3/insert [blocker]
thunderbolt3/storage-test [blocker]
thunderbolt3/remove [blocker]
wifi_interface_mode [non-blocker]
wireless/wifi_ap_open_b_no_sta_wlp0s20f3_manual [non-blocker]
wireless/wifi_ap_open_g_no_sta_wlp0s20f3_manual [non-blocker]
wireless/wifi_ap_wpa_b_no_sta_wlp0s20f3_manual [non-blocker]
wireless/wifi_ap_wpa_g_no_sta_wlp0s20f3_manual [non-blocker]
wwan/detect-manual [non-blocker]
wwan/check-sim-present-manual [non-blocker]
wwan/scan-networks-manual [non-blocker]
wwan/gsm-connection-interrupted-manual [non-blocker]
cpu/clocktest [non-blocker]
disk/stats_dm-1 [non-blocker]
wireless_sta_protocol [non-blocker]
wireless/wireless_connection_wpa_ac_nm_wlp0s20f3 [blocker]
wireless/wireless_connection_wpa_ax_nm_wlp0s20f3 [blocker]
wireless/wireless_connection_wpa3_ax_nm_wlp0s20f3 [blocker]
ethernet/ping_enp0s31f6 [blocker]
wireless/wireless_connection_wpa_bg_nm_wlp0s20f3 [blocker]
wireless/wireless_connection_wpa_n_nm_wlp0s20f3 [blocker]
wireless/wireless_connection_wpa_ax_np_wlp0s20f3 [blocker]
location/status [non-blocker]
cpu/topology [blocker]
wireless/wifi_ap_wpa_g_no_sta_wlp0s20f3_auto [non-blocker]
wireless/wifi_ap_open_b_no_sta_wlp0s20f3_auto [non-blocker]
wireless/wifi_ap_wpa_g_with_sta_wlp0s20f3_auto [non-blocker]
wireless/wireless_connection_open_ac_np_wlp0s20f3 [blocker]
wireless/wifi_ap_wpa_b_with_sta_wlp0s20f3_auto [non-blocker]
wireless/wireless_connection_open_ax_np_wlp0s20f3 [blocker]
wireless/wireless_connection_open_bg_nm_wlp0s20f3 [blocker]
audio/detect-capture-devices [non-blocker]
wireless/wireless_scanning_wlp0s20f3 [non-blocker]
disk/read_performance_dm-1 [non-blocker]
wireless/wireless_connection_wpa_ac_np_wlp0s20f3 [blocker]
wwan/detect [blocker]
wireless/wireless_connection_open_n_nm_wlp0s20f3 [blocker]
socketcan/modprobe_vcan [non-blocker]
socketcan/send_packet_local_eff_virtual [non-blocker]
wireless/wifi_ap_setup_wizard_wlp0s20f3_auto [non-blocker]
wireless/wireless_connection_wpa_n_np_wlp0s20f3 [blocker]
wireless/wifi_ap_open_g_no_sta_wlp0s20f3_auto [non-blocker]
wireless/check_iwlwifi_microcode_crash_wlp0s20f3 [non-blocker]
wireless/wireless_connection_open_ax_nm_wlp0s20f3 [blocker]
wireless/nmcli_wifi_ap_bg_wlp0s20f3 [non-blocker]
socketcan/send_packet_local_sff_virtual [non-blocker]
wireless/wireless_connection_open_bg_np_wlp0s20f3 [blocker]
bluetooth/detect-output [non-blocker]
bluetooth/bluetooth_obex_send [non-blocker]
disk/storage_device_dm-1 [non-blocker]
wireless/wireless_connection_open_n_np_wlp0s20f3 [blocker]
audio/alsa-loopback-automated [blocker]
socketcan/send_packet_local_fd_virtual [non-blocker]
wireless/wireless_connection_wpa3_ax_np_wlp0s20f3 [blocker]
ethernet/detect [blocker]
disk/detect [non-blocker]
wireless/wireless_connection_wpa_bg_np_wlp0s20f3 [blocker]
ipv6_detect [non-blocker]
ipv6_link_local_address_enp0s31f6 [non-blocker]
cpu_offlining [non-blocker]
cpu/offlining_test [non-blocker]
camera/detect [non-blocker]
camera/multiple-resolution-images_video0 [non-blocker]
wireless/detect [blocker]
usb/storage-detect [non-blocker]
wireless/nmcli_wifi_ap_a_wlp0s20f3 [non-blocker]
wireless/wifi_ap_wpa_b_no_sta_wlp0s20f3_auto [non-blocker]
wireless/wireless_connection_open_ac_nm_wlp0s20f3 [blocker]
suspend/suspend_advanced_auto [non-blocker]
after-suspend-audio/alsa-playback [blocker]
after-suspend-bluetooth/keyboard-manual [non-blocker]
after-suspend-ethernet/detect [blocker]
after-suspend-ethernet/hotplug-enp0s31f6 [blocker]
after-suspend-monitor/dvi [non-blocker]
after-suspend-monitor/hdmi [non-blocker]
after-suspend-monitor/dvi-to-vga [non-blocker]
after-suspend-monitor/hdmi-to-vga [non-blocker]
after-suspend-monitor/displayport_hotplug [non-blocker]
after-suspend-monitor/vga [non-blocker]
networking/info_device1_enp0s31f6 [non-blocker]
after-suspend-networking/info_device1_enp0s31f6 [blocker]
after-suspend-serial/rs232-console [non-blocker]
after-suspend-usb/hid [non-blocker]
after-suspend-usb/insert [non-blocker]
after-suspend-usb/storage-automated [non-blocker]
after-suspend-usb/remove [non-blocker]
after-suspend-usb-c/c-to-a-adapter/hid [non-blocker]
after-suspend-usb-c/c-to-a-adapter/insert [non-blocker]
after-suspend-usb-c/c-to-a-adapter/storage-automated [non-blocker]
after-suspend-usb-c/c-to-a-adapter/remove [non-blocker]
after-suspend-usb-c/hid [non-blocker]
after-suspend-usb-c/insert [non-blocker]
after-suspend-usb-c/storage-automated [non-blocker]
after-suspend-usb-c/remove [non-blocker]
after-suspend-usb-c-otg/g_serial [non-blocker]
after-suspend-usb-c-otg/g_serial-cleanup [non-blocker]
after-suspend-usb-c-otg/g_mass_storage [non-blocker]
after-suspend-usb-c-otg/g_mass_storage-cleanup [non-blocker]
after-suspend-usb-c-otg/g_ether [non-blocker]
after-suspend-usb-c-otg/g_ether-cleanup [non-blocker]
after-suspend-usb3/insert [non-blocker]
after-suspend-usb3/storage-automated [non-blocker]
after-suspend-usb3/remove [non-blocker]
after-suspend-thunderbolt3/insert [blocker]
after-suspend-thunderbolt3/storage-test [blocker]
after-suspend-thunderbolt3/remove [blocker]
after-suspend-wireless/wifi_ap_open_b_no_sta_wlp0s20f3_manual [non-blocker]
after-suspend-wireless/wifi_ap_open_g_no_sta_wlp0s20f3_manual [non-blocker]
after-suspend-wireless/wifi_ap_wpa_b_no_sta_wlp0s20f3_manual [non-blocker]
after-suspend-wireless/wifi_ap_wpa_g_no_sta_wlp0s20f3_manual [non-blocker]
after-suspend-wwan/detect-manual [non-blocker]
after-suspend-wwan/scan-networks-manual [non-blocker]
after-suspend-wwan/check-sim-present-manual [non-blocker]
after-suspend-wwan/gsm-connection-interrupted-manual [non-blocker]
firmware/fwts_desktop_diagnosis [non-blocker]
firmware/fwts_desktop_diagnosis_results.log.gz [non-blocker]
acpi/oem_osi [non-blocker]
bluetooth/detect [non-blocker]
bluetooth/bluez-controller-detect [non-blocker]
camera/roundtrip-qrcode_video0 [non-blocker]
cpu/scaling_test [blocker]
cpu/scaling_test-log-attach [non-blocker]
cpu/maxfreq_test [blocker]
cpu/maxfreq_test-log-attach [non-blocker]
cpu/cstates [blocker]
cpu/cstates_results.log [non-blocker]
disk/check-software-raid [non-blocker]
docker/info [non-blocker]
docker/version [non-blocker]
docker/run_ [non-blocker]
docker/interative_ [non-blocker]
docker/diff_ [non-blocker]
docker/copy_ [non-blocker]
docker/inspect_ [non-blocker]
docker/kill_ [non-blocker]
docker/build-single_ [non-blocker]
docker/start-stop_ [non-blocker]
docker/deploy-registry_ [non-blocker]
docker/export-and-import_ [non-blocker]
docker/save-and-load_ [non-blocker]
docker/commit_ [non-blocker]
docker/update_ [non-blocker]
docker/restart-on-failure_ [non-blocker]
docker/restart-always_ [non-blocker]
docker/compose-single_ [non-blocker]
docker/compose-and-basic_ [non-blocker]
docker/compose-restart_ [non-blocker]
i2c/i2c-bus-detect [blocker]
i2c/i2c-device-detect [blocker]
ubuntu_core_features [non-blocker]
kernel-snap/booted-kernel-matches-current-grub [non-blocker]
memory/info [blocker]
networking/predictable_names [non-blocker]
power-management/warm-reboot [blocker]
power-management/post-warm-reboot [blocker]
power-management/cold-reboot [blocker]
power-management/post-cold-reboot [blocker]
snappy/snap-list [non-blocker]
snappy/snap-search [non-blocker]
snappy/snap-install [non-blocker]
snappy/snap-refresh-automated [non-blocker]
snappy/snap-revert-automated [non-blocker]
snappy/snap-reupdate-automated [non-blocker]
snappy/snap-remove [non-blocker]
snappy/test-store-install-beta [non-blocker]
snappy/test-store-install-edge [non-blocker]
snappy/test-system-confinement [non-blocker]
snappy/test-snaps-confinement [non-blocker]
snap_revision_info [non-blocker]
snapd/snap-refresh-snapd-snapd-to-base-rev [non-blocker]
snapd/log-attach-after-snap-refresh-snapd-snapd-to-base-rev [non-blocker]
snapd/snap-verify-after-refresh-snapd-snapd-to-base-rev [non-blocker]
snapd/snap-revert-snapd-snapd-from-base-rev [non-blocker]
snapd/log-attach-after-snap-revert-snapd-snapd-from-base-rev [non-blocker]
snapd/snap-verify-after-revert-snapd-snapd-from-base-rev [non-blocker]
snapd/snap-refresh-snapd-snapd-to-stable-rev [non-blocker]
snapd/log-attach-after-snap-refresh-snapd-snapd-to-stable-rev [non-blocker]
tpm2/fwts-event-log-dump [non-blocker]
clevis-encrypt-tpm2/precheck [blocker]
clevis-encrypt-tpm2/detect-rsa-capabilities [blocker]
clevis-encrypt-tpm2/rsa [blocker]
clevis-encrypt-tpm2/detect-ecc-capabilities [blocker]
clevis-encrypt-tpm2/ecc [blocker]
watchdog/detect [non-blocker]
watchdog/systemd-config [non-blocker]
watchdog/trigger-system-reset-auto [non-blocker]
watchdog/post-trigger-system-reset-auto [non-blocker]
zapper_capabilities [non-blocker]
bluetooth/zapper-a2dp [non-blocker]
input/zapper-keyboard [non-blocker]
monitor/zapper-edid [non-blocker]
after-suspend-audio/detect-playback-devices [non-blocker]
after-suspend-audio/detect-capture-devices [non-blocker]
after-suspend-audio/alsa-loopback-automated [non-blocker]
after-suspend-bluetooth/bluetooth_obex_send [non-blocker]
after-suspend-ethernet/ping_enp0s31f6 [blocker]
after-suspend-location/status [non-blocker]
after-suspend-usb/storage-detect [non-blocker]
after-suspend-wireless/wireless_scanning_wlp0s20f3 [non-blocker]
after-suspend-wireless/wireless_connection_open_ax_nm_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_open_ac_nm_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_open_bg_nm_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_open_n_nm_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_wpa_ax_nm_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_wpa3_ax_nm_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_wpa_ac_nm_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_wpa_bg_nm_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_wpa_n_nm_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_open_ax_np_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_open_ac_np_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_open_bg_np_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_open_n_np_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_wpa_ax_np_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_wpa3_ax_np_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_wpa_ac_np_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_wpa_bg_np_wlp0s20f3 [blocker]
after-suspend-wireless/wireless_connection_wpa_n_np_wlp0s20f3 [blocker]
after-suspend-wireless/check_iwlwifi_microcode_crash_wlp0s20f3 [non-blocker]
after-suspend-wwan/detect [non-blocker]

The "Internet of Things Certified Hardware Coverage for Ubuntu Core 22 /
Ubuntu 22.04" document specifies what jobs should be considered as
blockers.

For IoT devices, the after-suspend jobs are not considered blockers, so
they have been left out.

Fix CER-2593
@pieqq pieqq changed the title Add cert-blocker status based on coverage guide Add cert-blocker status based on coverage guide for IoT test plans (BugFix) Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.32%. Comparing base (9318a5c) to head (dad92ea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage   43.32%   43.32%           
=======================================
  Files         356      356           
  Lines       38658    38658           
  Branches     6559     6559           
=======================================
  Hits        16750    16750           
  Misses      21245    21245           
  Partials      663      663           
Flag Coverage Δ
provider-base 16.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pieqq pieqq marked this pull request as draft April 24, 2024 10:06
@pieqq pieqq marked this pull request as ready for review April 25, 2024 03:49
@pieqq
Copy link
Collaborator Author

pieqq commented Apr 25, 2024

I've checked the cert-blocker status on the Desktop 22.04 test plan and it looks appropriate, so no changes are required. This PR is ready for review.

Copy link
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pieqq,
A few years earlier, there was a discussion between Cert/CE/OEMQA and the decision made in that meeting was[1]

Any job included in the project provider is a blocker

And the "CE IoT QA - Enablement Cycle QA Process" document has been updated according to that conclusion[2]

If we're now only adding blocker certification status according to the jammy test coverage guide then the certification scope will be changed for commercial enablement projects and ODM program projects as well.
Therefore I'd like to suggest applying blocker certification status to all the test jobs included in the client-cert-iot and client-cert-odm test plans.

[1] https://docs.google.com/document/d/1j0sOvJSODp_qlsTvjQcJA6umHSv-B18h8e506fz1sSE/edit#heading=h.6llmkwta1g0g
[2] https://docs.google.com/document/d/1QIaNbzu0bQXLMNTKPHJ21Tvb0upgHKb3UVvn0KQV6h8/edit#heading=h.pvqm21uto89l

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants