Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WIFI STAs resource job and Support Wifi 7 (New) #1175

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

seankingyang
Copy link
Contributor

@seankingyang seankingyang commented Apr 11, 2024

Description

  • Add new python script to get the STAs supported of wifi chip. (This will also get the support band frequency)

Resolved issues

Documentation

Tests

slide load on checkbox deb version

wireless_sta_protocol

RTL8821CE:

===========================[ Running Selected Jobs ]============================
==============[ Running job 1 / 1. Estimated time left: 0:00:00 ]===============
-----------[ Resource job to identify Wi-Fi STA supported protocols ]-----------
ID: com.canonical.certification::wireless_sta_protocol
Category: com.canonical.certification::information_gathering
... 8< -------------------------------------------------------------------------
wlp2s0_2.4GHz: supported
wlp2s0_5GHz: supported
wlp2s0_6GHz: unsupported
wlp2s0_be: unsupported
wlp2s0_ax: unsupported
wlp2s0_ac: supported
------------------------------------------------------------------------- >8 ---
Outcome: job passed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2024-04-11T08.25.41
==================================[ Results ]===================================
 ☑ : Resource job to identify Wi-Fi STA supported protocols

AX211:

===========================[ Running Selected Jobs ]============================
==============[ Running job 1 / 1. Estimated time left: 0:00:00 ]===============
-----------[ Resource job to identify Wi-Fi STA supported protocols ]-----------
ID: com.canonical.certification::wireless_sta_protocol
Category: com.canonical.certification::information_gathering
... 8< -------------------------------------------------------------------------
wlp0s20f3_2.4GHz: supported
wlp0s20f3_5GHz: supported
wlp0s20f3_6GHz: unsupported
wlp0s20f3_be: unsupported
wlp0s20f3_ax: supported
wlp0s20f3_ac: supported
------------------------------------------------------------------------- >8 ---
Outcome: job passed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2024-04-11T08.50.17
==================================[ Results ]===================================
 ☑ : Resource job to identify Wi-Fi STA supported protocols

BE200 on jammy:

===========================[ Running Selected Jobs ]============================
==============[ Running job 1 / 1. Estimated time left: 0:00:00 ]===============
-----------[ Resource job to identify Wi-Fi STA supported protocols ]-----------
ID: com.canonical.certification::wireless_sta_protocol               
Category: com.canonical.certification::information_gathering          
... 8< -------------------------------------------------------------------------
wlp87s0f0_2.4GHz: supported                                                                  
wlp87s0f0_5GHz: supported                                                                                                                                                                 
wlp87s0f0_6GHz: unsupported                                                                  
wlp87s0f0_be: unsupported                                                                    
wlp87s0f0_ax: supported                                                                                                                                                                   
wlp87s0f0_ac: supported                                                                                                                                                                   
------------------------------------------------------------------------- >8 ---
Outcome: job passed                                                                          
Finalizing session that hasn't been submitted anywhere: checkbox-run-2024-04-11T09.02.31
==================================[ Results ]===================================
 ☑ : Resource job to identify Wi-Fi STA supported protocols  

BE200 on noble

===========================[ Running Selected Jobs ]============================
==============[ Running job 1 / 1. Estimated time left: 0:00:00 ]===============
-----------[ Resource job to identify Wi-Fi STA supported protocols ]-----------
ID: com.canonical.certification::wireless_sta_protocol
Category: com.canonical.certification::information_gathering
... 8< -------------------------------------------------------------------------
wlp114s0f0_2.4GHz: supported
wlp114s0f0_5GHz: supported
wlp114s0f0_6GHz: unsupported
wlp114s0f0_be: supported
wlp114s0f0_ax: supported
wlp114s0f0_ac: supported
------------------------------------------------------------------------- >8 ---
Outcome: job passed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2024-04-11T09.07.23
==================================[ Results ]===================================
 ☑ : Resource job to identify Wi-Fi STA supported protocols

QCNFA765 support 6GHz:

===========================[ Running Selected Jobs ]============================
==============[ Running job 1 / 1. Estimated time left: 0:00:00 ]===============
-----------[ Resource job to identify Wi-Fi STA supported protocols ]-----------
ID: com.canonical.certification::wireless_sta_protocol
Category: com.canonical.certification::information_gathering
... 8< -------------------------------------------------------------------------
wlp2s0_2.4GHz: supported
wlp2s0_5GHz: supported
wlp2s0_6GHz: supported
wlp2s0_be: unsupported
wlp2s0_ax: supported
wlp2s0_ac: supported
------------------------------------------------------------------------- >8 ---
Outcome: job passed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2024-04-11T09.21.38
==================================[ Results ]===================================
 ☑ : Resource job to identify Wi-Fi STA supported protocols

Run Desktop auto test plan (client-cert-desktop-22-04-automated)

only select the wireless category

202201-29926 QCN765 only support up to AC
202402-33474 BE200 in noble support up to BE

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 43.27%. Comparing base (268c743) to head (6d3913f).
Report is 28 commits behind head on main.

Files Patch % Lines
providers/resource/bin/WIFI_phy.py 98.07% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
+ Coverage   43.19%   43.27%   +0.07%     
==========================================
  Files         356      357       +1     
  Lines       38653    38705      +52     
  Branches     6561     6571      +10     
==========================================
+ Hits        16697    16748      +51     
  Misses      21293    21293              
- Partials      663      664       +1     
Flag Coverage Δ
provider-resource 32.48% <98.07%> (+3.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seankingyang seankingyang marked this pull request as draft April 11, 2024 08:11
@seankingyang seankingyang force-pushed the Refactor_WIFI_STAs_Job_and_Add_WIFI_7_job branch 3 times, most recently from b749e08 to 40a5997 Compare April 12, 2024 04:28
@seankingyang seankingyang marked this pull request as ready for review April 12, 2024 06:34
Copy link
Contributor

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seankingyang, please see my inline comments.

providers/resource/bin/WIFI_phy.py Outdated Show resolved Hide resolved
providers/resource/bin/WIFI_phy.py Outdated Show resolved Hide resolved
providers/resource/bin/WIFI_phy.py Outdated Show resolved Hide resolved
providers/resource/bin/WIFI_phy.py Show resolved Hide resolved
providers/resource/bin/WIFI_phy.py Show resolved Hide resolved
providers/resource/bin/WIFI_phy.py Outdated Show resolved Hide resolved
providers/resource/bin/WIFI_phy.py Outdated Show resolved Hide resolved
@seankingyang seankingyang force-pushed the Refactor_WIFI_STAs_Job_and_Add_WIFI_7_job branch from f42683d to 3c9c503 Compare April 15, 2024 07:58
@pieqq pieqq marked this pull request as draft April 15, 2024 09:48
@pieqq pieqq marked this pull request as ready for review April 15, 2024 09:48
@seankingyang seankingyang marked this pull request as draft April 15, 2024 10:00
@seankingyang seankingyang marked this pull request as ready for review April 15, 2024 10:01
@seankingyang seankingyang reopened this Apr 15, 2024
Copy link
Contributor

@rickwu666666 rickwu666666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Issac,
Sorry for jumping. But, Do you think we can add information about interface mode support then we can replace id: wifi_interface_mode as well?

providers/resource/bin/WIFI_phy.py Show resolved Hide resolved
providers/resource/bin/WIFI_phy.py Show resolved Hide resolved
providers/resource/bin/WIFI_phy.py Show resolved Hide resolved
providers/resource/bin/WIFI_phy.py Show resolved Hide resolved
@rickwu666666
Copy link
Contributor

Hi Issac, Sorry for jumping. But, Do you think we can add information about interface mode support then we can replace id: wifi_interface_mode as well?

As per-discussed in the meeting. This requirement will be divided into different PR later on.

@seankingyang
Copy link
Contributor Author

seankingyang commented May 3, 2024

Seperate the support WIFI 7 (BE) test cases in next PR #1224 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants