Included firmware revision and hw revision for wwan resource job (Bugfix)

[stanley31huang]

Description

We would like to collect the firmware revision and hardware revision in the wwan resource job, so we could have the enough information to identify any regression issues related WWAN device.

Resolved issues

N/A

Documentation

N/A

Tests

Tested on one x86 platform running server image

u@u-Alder-Lake-Client-Platform:~$ checkbox-iiotg-classic.checkbox-cli run com.canonical.certification::wwan_resource
$PROVIDERPATH is defined, so following provider sources are ignored ['/snap/checkbox-iiotg-classic/79/providers/checkbox-provider-intliotg', '/home/u/.local/share/plainbox-providers-1', '/var/tmp/checkbox-providers-develop'] 
Using sideloaded provider: checkbox-provider-base, version 4.0.0.dev194 from /var/tmp/checkbox-providers/base
===========================[ Running Selected Jobs ]============================
==============[ Running job 1 / 1. Estimated time left: 0:00:03 ]===============
--------------------[ Gather device info about WWAN modems ]--------------------
ID: com.canonical.certification::wwan_resource
Category: com.canonical.certification::wwan
... 8< -------------------------------------------------------------------------
mm_id: 0
hw_id: 
manufacturer: generic
model: MBIM [14C3:4D75]
firmware_revision: 81600.0000.00.29.21.24_GC D24
hardware_revision: V1.0.6

------------------------------------------------------------------------- >8 ---
Outcome: job passed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2024-04-10T03.28.23
==================================[ Results ]===================================
 ☑ : Gather device info about WWAN modems

# To ensure we could get the information through mmcli
u@u-Alder-Lake-Client-Platform:~$ python3 /var/tmp/checkbox-providers/base/bin/wwan_tests.py resources --use-cli
mm_id: 0
hw_id: None
manufacturer: generic
model: MBIM[14C3:4D75]
firmware_revision: 81600.0000.00.29.21.24_GC
hardware_revision: V1.0.6

# To ensure we could get the information through dbus
u@u-Alder-Lake-Client-Platform:~$ python3 /var/tmp/checkbox-providers/base/bin/wwan_tests.py resources 
mm_id: 0
hw_id: 
manufacturer: generic
model: MBIM [14C3:4D75]
firmware_revision: 81600.0000.00.29.21.24_GC D24
hardware_revision: V1.0.6

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.44%. Comparing base (6f0ca4e) to head (eb16794).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   43.21%   43.44%   +0.22%     
==========================================
  Files         356      356              
  Lines       38662    38674      +12     
  Branches     6561     6561              
==========================================
+ Hits        16706    16800      +94     
+ Misses      21293    21211      -82     
  Partials      663      663              

Flag	Coverage Δ
provider-base	16.89% <100.00%> (+0.60%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pieqq]

Thanks for submitting this!

I left a comment inline, because I think the unit tests are a bit convoluted. I propose another method.

[kissiel]

I think the mocking in the test is broken.

[Hook25]

+1, LGTM

Code was updated