Improve job definition layout and contents in a handful of dirs in the base providers (BugFix) #1088
+465
−441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook25
requested changes
Mar 21, 2024
| Tests that the systems wireless hardware can connect to a router using WPA | ||
| security and the 802.11b/g protocols after the system has been suspended. | ||
| _purpose: Tests that the system's wireless hardware can connect to a router using WPA security and the 802.11b/g protocols after the system has been suspended. | ||
| _summary: Ensure wireless hardware can connect using WPA and 802.11b/g after suspend. |
There was a problem hiding this comment.
Suggested change
| _summary: Ensure wireless hardware can connect using WPA and 802.11b/g after suspend. |
Duplicated
| 5. Connect a Thunderbolt monitor to the docking station. | ||
| 6. Connect a Thunderbolt3 storage to the docking station. | ||
| 7. Connect a USB Type-C storage to the docking station. | ||
| 8. Connect a USB3.0 storage to the docking station. | ||
| 9. Connect a headset to the docking station. | ||
| _verification: | ||
| Mark it Pass if you have connected all I/O ports as mentioned above. | ||
| _summary: | ||
| Verify the initial setup of all I/O ports on the docking station by connecting various devices and ensure they meet the dock's specification. |
There was a problem hiding this comment.
Suggested change
| Verify the initial setup of all I/O ports on the docking station by connecting various devices and ensure they meet the dock's specification. | |
| Prepare all I/O ports on the dock by connecting all devices it supports. |
Summary is wrong and long
Applied Max's suggestions (except one) Co-authored-by: Massimiliano <massimiliano.girardi@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another portion of changes done by the pxu-fixer.
I added the hunks by hand to do a front-line review.
The changes proposed here are/should be only cosmetic.