Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: load axe-devtools extension in dev mode #4247

Merged
merged 1 commit into from May 22, 2024
Merged

Conversation

barmac
Copy link
Contributor

@barmac barmac commented Apr 16, 2024

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Apr 16, 2024
@barmac
Copy link
Contributor Author

barmac commented Apr 16, 2024

Axe doesn't work yet, but at least the React extension is up again.

image image

@barmac barmac added the ready Ready to be worked on label Apr 22, 2024 — with bpmn-io-tasks
@barmac barmac removed the in progress Currently worked on label Apr 22, 2024
@barmac
Copy link
Contributor Author

barmac commented May 21, 2024

We could also try installing WAVE; it’s not the recommended tool, but if it works in Chromium, we can at least get started.

@lmbateman

@barmac
Copy link
Contributor Author

barmac commented May 22, 2024

I checked WAVE but it's not available in the devtools but you need to click the icon which is not displayed in the Modeler: https://chromewebstore.google.com/detail/wave-evaluation-tool/jbbplnpkjmmeebjpijfedlgcdilocofh?pli=1

@barmac
Copy link
Contributor Author

barmac commented May 22, 2024

Idea: Instead of trying to make devtools work, use axe-core to generate a report. This could be a Modeler plugin.

@barmac barmac force-pushed the load-axe-extension branch 2 times, most recently from f6a1405 to 35e7b95 Compare May 22, 2024 10:07
@barmac barmac marked this pull request as ready for review May 22, 2024 10:07
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels May 22, 2024
@barmac
Copy link
Contributor Author

barmac commented May 22, 2024

I got the axe-devtools extension running. To make it load the URL correctly, you need to reload the application window once. Have a look at the recording below:

Screen.Recording.2024-05-22.at.12.11.11.mov

@barmac barmac merged commit 32f87e5 into develop May 22, 2024
11 of 12 checks passed
@barmac barmac deleted the load-axe-extension branch May 22, 2024 10:14
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants