Tomcat10 support latest master #4342
Draft
+2,339
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanavasileva
added
ci:all-as
psavidis
added
ci:skipTests
yanavasileva
removed
ci:all-as
psavidis
added
the
ci:skipTests
psavidis
force-pushed
the
tomcat10_support_latest_master
branch
4 times, most recently
from
52127f5
to
e64463e
Compare
psavidis
removed
ci:skipTests
psavidis
force-pushed
the
tomcat10_support_latest_master
branch
from
487eddf
to
b7b7328
Compare
This was referenced May 29, 2024
Description: This commit can be broken down into the following changes: - Use version.tomcat9 for tomcat 9 and version.tomcat property for tomcat 10 respectively - Add tomcat assembly config to camunda-engine-rest-jakarta - Add new module `camunda-tomcat-assembly-jakarta` which produces a tomcat 10 configured with the jakarta namespace - Add configuration to produce a tomcat webapp based on the jakarta namespace - Add configuration to tomcat distro module to output both tomcat 9 & 10 distributions Related-to: #2471
Renames include: - References in tomcat 9 xml config - The runtime directory (to differentiate it from latest tomcat) - tomcat 9 maven profiles
- Tomcat 10 starts on QA Tests and then SLF4J clashes - Add Tomcat 10 (not finished) profile for shared-engine
Other noteable changes: - same resteasy version for jakarta webapp, engine-rest Resteasy starts during webapp-integration tests against tomcat 10 but tomcat logs of the engine do not appear. As a result, the engine does not start correctly and the tests get a timeout against the rest health check
The Servlet Parameter for registering the Application was wrong. Changed it to use the jakarta namespace.
- Replaces the weld-servlet-shaded with the core artifact and includes all the jakarta API dependencies in the shrinkwrap wars - see DeploymentHelper - The above fixes weld exception messages in the logs
- Add flag that skips the surefire unit tests of the integration-tests module - Use the flag upon calling the webapp integration tests for tomcat 10
psavidis
force-pushed
the
tomcat10_support_latest_master
branch
from
b7b7328
to
75af30a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-to: #2471