fix(job-executor): Adding helpful debug logs to improve job acquisition and job execution logging. Issue#2666.

[prakashpalanisamy]

This code change adds additional logging to Camunda Job Executor and scoped to the Job Acquisition and Job Execution.

#2666

[CLAassistant]

All committers have signed the CLA.

[yanavasileva]

Hi @prakashpalanisamy,

Thank you for raising this.
We will have a look at it and get back to you.

Best,
Yana

[yanavasileva]

@prakashpalanisamy, nice work!
I left a few comments for the code formatting (check all of the code for missing spaces) and covering the non-Spring use cases.

In addition to the changes, could you have have a look at adding a few test cases for the logging. The logging rule can be helpful for them. You can see examples here:

• https://github.com/camunda/camunda-bpm-platform/blob/master/engine/src/test/java/org/camunda/bpm/engine/test/jobexecutor/JobExecutorAcquireJobsForPriorityRangeTest.java#L164-L176
• https://github.com/camunda/camunda-bpm-platform/blob/master/engine/src/test/java/org/camunda/bpm/engine/test/jobexecutor/JobExceptionLoggingTest.java#L77-L96

[yanavasileva]

❓ The code is called only for Spring use cases. Have you considered how to log the same data for non-Spring scenario? As I don't think the ticket is created only for Spring use cases.
Hint:

camunda-bpm-platform/engine/src/main/java/org/camunda/bpm/engine/impl/jobexecutor/DefaultJobExecutor.java

Lines 43 to 45 in 5df0514

	protected int queueSize = 3;
	protected int corePoolSize = 3;
	protected int maxPoolSize = 10;

[prakashpalanisamy]

@yanavasileva , Thank you for taking your time to review. Ill look at the comments and update you. Thanks!!

[yanavasileva]

Closing due to inactivity. The PR can be reopened again when you get back to the topic.