New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Saving Marks Should Include User's X, Y, Zoom, etc #844"" #958

Merged

birm merged 1 commit into develop from revert-942-revert-902-yukaUU-save_marks_Include_userXYZoom

Apr 20, 2024

Member

birm commented Apr 20, 2024

Reverts #942 which reverted #902
Apparently we're indecisive here. Making this for deeper test/review


          Revert "Revert "Saving Marks Should Include User's X, Y, Zoom, etc #844…

c16b23b

…""

Member Author

birm commented Apr 20, 2024

I'm merging this back in. The issue is that clicking the annotation triggers a update, re #943 ; so the issue is there and not here.

Apologies to @YukaUU who did the task correctly, but I got jumpy seeing the bug caused with this change interacting with #943 and reverted.

birm merged commit b5bd7c5 into develop

1 of 2 checks passed

birm deleted the revert-942-revert-902-yukaUU-save_marks_Include_userXYZoom branch

April 20, 2024 02:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment