Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed disabled in mobile view #830 #854

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

Ayesh-07
Copy link
Contributor

Fixed disabled in mobile view #830

Summary

Remove the user-scalable="no" parameter from the content attribute to allow zooming.
Add maximum-scale=2.0 for ensuring that the maximum-scale parameter is not less than 2 to allow sufficient zooming.

By removing the user-scalable="no" parameter and ensuring the maximum-scale parameter is set appropriately, users will be able to zoom in and out on the Info Page in mobile view, improving accessibility for people with low vision.

Motivation

I'm passionate about contributing to the caMicroscope organization to further my skills and knowledge. One of the issues I've successfully fixed is #830, which involved addressing the disabled zooming on the mobile view of the Info Page. I would appreciate a review of my work to ensure it meets the project's standards. This experience has deepened my understanding of user-centered design and my ability to create intuitive user interfaces.

Copy link
Contributor

@nwanduka nwanduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Ayesh-07. Well done. We'll have to wait for our mentor, @birm to review the PR and offer his feedback before it can be merged.

@birm birm changed the base branch from master to develop March 26, 2024 14:42
@birm
Copy link
Member

birm commented Mar 26, 2024

Out of curiosity, why just info.html?

@birm birm merged commit c7e7968 into camicroscope:develop Mar 26, 2024
@Ayesh-07
Copy link
Contributor Author

Out of curiosity, why just info.html?

@birm
I focused on Info.html because that's where I first noticed the problem with zooming on mobile view. The issue is that users are unable to zoom in or out on the table in mobile view, which is critical for viewing the entire table content. If you need me to look into other pages, please let me know.

@nwanduka
Copy link
Contributor

Thank you @Ayesh-07 for this. I checked the other pages and noticed the issue is also present in the Slides and Signup pages. I fixed them in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants