Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Project Properly installable via CMake #148

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Jan 14, 2024

  1. Modified CMakeList.txt to be installable, now accessible through mood…

    …ycamel::readerwriterqueue in both subdirectory and installed cmake project (didn't change targets that were already avaible, though projectect previously didn't work as an installable cmake project) also added test targets disabled by default configurable with variable psuedo namespaced 'MOODYCAMEL_READERWRITERQUEUE_ENABLE_TESTS', test targets are unittests and stabtest, completely ignores msvc project files and make files, so no need for those going forward, and though better practice would be to change the includes to be more target friendly (not use bespoke relative includes), I decided not to change that, so the previous way to build and run the test will *also* still work. Added best pairing of MSVC equivalent compile commands I could find, and I verified all tests build and run correctly on Windows 11 with MSVC 14.38.33130
    Cazadorro committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    a3346b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    febad56 View commit details
    Browse the repository at this point in the history
  3. Fixed misleading comment

    Cazadorro committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    03600f4 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. made comments more informative, added configuration sets of compile a…

    …rguments for release, debug and relwithdebinfo for tests, otherwise would force relwithdebinfo or fail to compile.
    Cazadorro committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6f613d5 View commit details
    Browse the repository at this point in the history
  2. moved -DNDEBUG into target_compile_definitions where it belongs, prob…

    …ably not needed, believe configs add this anyway, but it doesn't hurt to add
    Cazadorro committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7a59357 View commit details
    Browse the repository at this point in the history
  3. inverted the logic on target compile definitions, meant to do relaese…

    … and relaase with debuginfo *with out* assertions running, fixed generator statements, and moved include for GNUInstallDirs so it no longer complains about it's location
    Cazadorro committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c2d3567 View commit details
    Browse the repository at this point in the history