Skip to content

Commit

Permalink
#1011 - Upgrade to IDEA 2024.1 (#1013)
Browse files Browse the repository at this point in the history
* #1011 - Upgrade to IDEA 2024.1

* Upgrade to jdk17 instead of jdk11 for some tests

* Attempt to fix tests
  • Loading branch information
davsclaus committed Apr 14, 2024
1 parent dc1b3db commit b3b8fed
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 36 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-build.yaml
Expand Up @@ -40,7 +40,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
version: [2023.1.3, 2023.2.5, 2023.3.6]
version: [2023.1.3, 2023.2.5, 2023.3.6, 2024.1]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion build-all.sh
@@ -1,5 +1,5 @@
#!/bin/bash

for v in "2023.1.3" "2023.2.5" "2023.3.6"; do
for v in "2023.1.3" "2023.2.5" "2023.3.6" "2024.1; do
./build.sh $v
done
4 changes: 2 additions & 2 deletions camel-idea-plugin/build.gradle
Expand Up @@ -33,11 +33,11 @@ intellij {
// http://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/build_number_ranges.html
patchPluginXml {
sinceBuild = "231"
untilBuild = "233.*"
untilBuild = "241.*"
}

runPluginVerifier {
ideVersions = [ "2023.1", "2023.2", "2023.3" ]
ideVersions = [ "2023.1", "2023.2", "2023.3", "2024.1" ]
}

// publishPlugin {
Expand Down
1 change: 1 addition & 0 deletions camel-idea-plugin/src/main/resources/META-INF/plugin.xml
Expand Up @@ -12,6 +12,7 @@
v.1.2.7
<ul>
<li>Upgrade to Camel 4.5.0</li>
<li>IDEA 2024.1 supported</li>
</ul>
]]>
</change-notes>
Expand Down
Expand Up @@ -161,7 +161,7 @@ protected LightProjectDescriptor getProjectDescriptor() {
return new DefaultLightProjectDescriptor() {
@Override
public Sdk getSdk() {
return IdeaTestUtil.getMockJdk11();
return IdeaTestUtil.getMockJdk17();
}

@Override
Expand Down
Expand Up @@ -35,7 +35,7 @@ protected LightProjectDescriptor getProjectDescriptor() {
return new DefaultLightProjectDescriptor() {
@Override
public Sdk getSdk() {
return IdeaTestUtil.getMockJdk11();
return IdeaTestUtil.getMockJdk17();
}

@Override
Expand Down
Expand Up @@ -16,12 +16,11 @@
*/
package com.github.cameltooling.idea.util;

import com.github.cameltooling.idea.service.CamelService;
import com.github.cameltooling.idea.CamelLightCodeInsightFixtureTestCaseIT;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiLiteralExpression;
import com.intellij.testFramework.fixtures.LightJavaCodeInsightFixtureTestCase;

public class IdeaUtilsIsCamelRouteStartExtendedTestIT extends LightJavaCodeInsightFixtureTestCase {
public class IdeaUtilsIsCamelRouteStartExtendedTestIT extends CamelLightCodeInsightFixtureTestCaseIT {

private static final String CODE = "import org.apache.camel.builder.RouteBuilder;\n"
+ "\n"
Expand All @@ -40,17 +39,6 @@ public class IdeaUtilsIsCamelRouteStartExtendedTestIT extends LightJavaCodeInsig
+ "\n"
+ "}\n";

@Override
protected void setUp() throws Exception {
super.setUp();
myFixture.getProject().getService(CamelService.class).setCamelPresent(true);
}

@Override
protected String getTestDataPath() {
return "src/test/resources/testData/";
}

public void testStartRoute() {
// caret is at start of rout in the test java file
myFixture.configureByText("DummyTestData.java", CODE);
Expand Down
Expand Up @@ -19,16 +19,15 @@
import java.util.ArrayList;
import java.util.List;

import com.github.cameltooling.idea.service.CamelService;
import com.github.cameltooling.idea.CamelLightCodeInsightFixtureTestCaseIT;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiFile;
import com.intellij.psi.PsiLiteralExpression;
import com.intellij.psi.PsiReferenceExpression;
import com.intellij.psi.PsiVariable;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.testFramework.fixtures.LightJavaCodeInsightFixtureTestCase;

public class IdeaUtilsIsCamelRouteStartTestIT extends LightJavaCodeInsightFixtureTestCase {
public class IdeaUtilsIsCamelRouteStartTestIT extends CamelLightCodeInsightFixtureTestCaseIT {

private static final String CODE = "import org.apache.camel.builder.RouteBuilder;\n"
+ "\n"
Expand Down Expand Up @@ -69,17 +68,6 @@ public class IdeaUtilsIsCamelRouteStartTestIT extends LightJavaCodeInsightFixtur
+ "\n"
+ "}\n";

@Override
protected void setUp() throws Exception {
super.setUp();
myFixture.getProject().getService(CamelService.class).setCamelPresent(true);
}

@Override
protected String getTestDataPath() {
return "src/test/resources/testData/";
}

public void testStartRoute() {
// caret is at start of rout in the test java file
myFixture.configureByText("DummyTestData.java", CODE);
Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
@@ -1,6 +1,6 @@
camelVersion = 4.5.0
camelQuarkusVersion = 3.9.0
camelKameletVersion = 4.4.1
camelKameletVersion = 4.5.0
camelKarafVersion = 3.22.1
ideaVersion=2023.3.6
ideaVersion=2024.1
mavenResolverVersion=1.9.18

0 comments on commit b3b8fed

Please sign in to comment.