fix: remove deprecated use of defaultProps #4385
Open
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @timbocole, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
timbocole
changed the title
|
LGTM, This will be on version 5.12.4 |
sethimcclaine
approved these changes
May 9, 2024
|
Hi @gedu @sethimcclaine any Idea when is 5.12.4 scheduled for? |
|
Hi all!! Thanks for the work!. So I shall wait until the next release ? and ignore the error message? Thanks!!!!! |
dandresfg
approved these changes
May 16, 2024
SantiagoSiordia
approved these changes
May 16, 2024
This was referenced May 17, 2024
Hey, we are trying to upgrade paper to support almost latest RN version, and after that we will submit it, I hope as soon as possible |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR prevents the error log warning the "defaultProps" will be removed (visible in RN0.74.0)
Related issue
Addresses #4382
Test plan
Ensure that use of the
TextInputIcondoes not produce the error (included in linked issue) when run using RN0.74.0