feat: add activity indicator to TextInput (#1) #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new TextInput.ActivityIndicator to use with TextInput right and left props
--> This will show either the native activity indicator or the RN Paper Activity Indicator,
based on the value of the useNativeActivityIndicator prop
---------
Co-authored-by: Brandon Pelton-Cox <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the value of the useNativeActivityIndicator prop
Co-authored-by: Brandon Pelton-Cox <>
Motivation
Add support to show either the native activity indicator or the React Native Paper version in TextInput. This was motivated mainly by this open issue.
Related issue
Test plan
I added examples to the example app. Simply checkout this PR, install deps and run
yarn example startand see the pertinent changes in theTextInputarea of the app.