Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow passthrough of safeAreaInsets on Appbar.Header #4331

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chrysb
Copy link

@chrysb chrysb commented Mar 3, 2024

Motivation

If you use Appbar.Header within a <SafeAreaView> — there's no way to remove the top padding if you don't want it.

safeAreaInsets is a valid prop for this component, but setting it does nothing.

    <Appbar.Header
      safeAreaInsets={{ top: 0 }}
    >

This PR allows developers to have control over the insets of this component.

Test plan

This is a two line change, but as I'm not intimately familiar with this repo, I might be overlooking something.

To test, simply modify the safeAreaInsets on the Appbar.Header to modify the top padding.

@callstack-bot
Copy link

callstack-bot commented Mar 3, 2024

Hey @chrysb, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants