feat: pressable card title #4191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewalczak
reviewed
Nov 28, 2023
src/components/Card/CardTitle.tsx
Outdated
| @@ -169,7 +176,18 @@ const CardTitle = ({ | |||
| ) : null} | |||
|
|
|||
| <View style={[styles.titles]}> | |||
| {title && ( | |||
| {title && onPressTitle ? ( | |||
| <TouchableOpacity onPress={onPressTitle} style={[styles.title]}> | |||
There was a problem hiding this comment.
Avoid code repetition and move the title outside the render then used wrapped in pressable and without it.
There was a problem hiding this comment.
After moving the Title component from the render, I did the same for subtitle to keep preserve coding style consistency, also had to rename some variables
There was a problem hiding this comment.
Are the changes okay? Or Is there something I have to correct? @lukewalczak
lukewalczak
reviewed
Nov 28, 2023
src/components/Card/CardTitle.tsx
Outdated
| @@ -169,7 +176,18 @@ const CardTitle = ({ | |||
| ) : null} | |||
|
|
|||
| <View style={[styles.titles]}> | |||
| {title && ( | |||
| {title && onPressTitle ? ( | |||
| <TouchableOpacity onPress={onPressTitle} style={[styles.title]}> | |||
There was a problem hiding this comment.
Use Pressable instead of TouchableOpacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I needed the option to press the card title
Test plan
Two test cases on the Card.Title component
- Card.Title without onPressTitle props {...props, onPressTitle:undefined}
make sure the card functions normally
- Card.Title with onPressTitle props = () => {Alert.alert("Pressed")}
Both are tested in the Card example馃憞
After press event on card title