New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TextInput loses focus inside Banner on iOS only #4179
Open
abdulbasithqb
wants to merge
4
commits into
callstack:main
Choose a base branch
from
qburst:fixes/banner-focus-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: TextInput loses focus inside Banner on iOS only callstack#4178
abdulbasithqb
changed the title
Fixes/banner focus fix
fix: TextInput loses focus inside Banner on iOS only
Nov 13, 2023
Hey @abdulbasithqb, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
reviewed
Nov 28, 2023
fix: removed duplicated style content
lukewalczak
previously approved these changes
Jan 8, 2024
lukewalczak
dismissed
their stale review
January 10, 2024 20:38
It may break a layout for users who pass a component as a child into the Banner
component
any suggestion to resolve this issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
TextInput loses focus every type a character is entered and keyboard is dismissed. This happens only on iOS real device.
On android real device it works as expected.
Related issue
issue #4178
Result