bugfix(JstlLocalization): fix parsing utf8 strings

[khajavi]

Issue solved: caelum/mamute#190

[Turini]

Hi @khajavi, thanks for sending us this PR. I'm just not sure if adding it to the
framework's core would be a good ideia, since ISO-8859 are expected when
reading properties files. Let's see what another devs say about that. cc/@lucascs

anyway, you're able to fix it easily by specializing JstlLocalization in your app:

@Specializes @RequestScoped
public class CustomJstlLocalization extends JstlLocalization {

    @Override @Produces
    public ResourceBundle getBundle(Locale locale) { /* custom code */ }
}

[csokol]

Apparently is possible to load UTF-8 encoded data from properties file. I think this is useful for languages with non ocidental alphabets (arabic, russian, etc).

@khajavi is having an issue because of that in Mamute while trying to translate the website content to his language, check caelum/mamute#190.

We can add this custom component to Mamute core, but I think that other VRaptor users might have the same problem in the future. What do you think?

I'm not sure if this is the best solution yet (forcing utf-8 properties for everyone) and we should probably improve this code and add tests before merging but I think it is worth of discussing a solution in this PR.

[cpfeiffer]

Even if it's possible to read property files as UTF-8, it would cause problems with all other tools that read/write these files, e.g. IDE editors, which assume the standard latin1 encoding.

Even if the encoding is latin1, it's still possible to embed unicode characters with the unicode escape syntax.

I'm not sure how comfortable it is to create such files, though. The eclipse property file editor for example actually creates unicode escape sequences when entering non-latin1 characters in to a property file.

[lucascs]

Be extremely careful with this!

properties file are ISO-8859-1 by specification, every properties tool will consider that.

Also you simply cannot change the default to UTF-8 because all projects already running VRaptor today are certainly using ISO-8859-1 for properties files.

[lucascs]

use try-with-resources here.

[Turini]

@khajavi we left a few suggestions on your code, can you take a look on it?
after that we can 🚀 this pr

[angeliski]

Hey @khajavi Can I help you to improve the code? I would like to approve that pull request. :)