Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplayer engine sound #1505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Multiplayer engine sound #1505

wants to merge 1 commit into from

Conversation

hbeni
Copy link
Contributor

@hbeni hbeni commented Apr 20, 2024

Adds engine sound to remote instances in multiplayer, so other c172 can be heard for example when taxiing

@hbeni
Copy link
Contributor Author

hbeni commented Apr 20, 2024

ℹ️ Note: This was developed against 2020.3.19 and verified OK.

Current next as of now has an issue preventing all remote sounds to be played. This is however nothing to be fixed at the aircraft side.

@wlbragg
Copy link
Collaborator

wlbragg commented Apr 20, 2024

@hbeni does the failure of 2020.4 sound have anything to do with the "type"?

Also, a while back we discussed, and I am pretty sure there were changes made to the fgcommand sound system. Addons use this sound system. I was having difficulty getting the addon sound to work. It ended up being the lack of defining the "queue" parameter.

see:

var sound_alert = {path: "[addon=org.flightgear.addons.missiongenerator]Sounds", file: "alarm.wav", volume:1.0, queue:"instant"};

fgcommand("play-audio-sample", props.Node.new(sound_alert));

I don't know that this would have anything to do with the FX sound system or even if the MP is using the FX sound system or if it is something else such as "mp"?

Anyway, I just wanted to bring it up in case it pertains to the issue.

@hbeni
Copy link
Contributor Author

hbeni commented Apr 20, 2024

I don't know that this would have anything to do with the FX sound system or even if the MP is using the FX sound system or if it is something else such as "mp"?

I think it uses the "ordinary" fx sound system. And it should work like for all other "normal" sounds, at least per the wiki. And in 2020.3 it does! No fgcommands involved.

@hbeni
Copy link
Contributor Author

hbeni commented Apr 20, 2024

Opened a SF ticket for investigation: https://sourceforge.net/p/flightgear/codetickets/2883/

It's your call if you want to merge... (maybe backport to 2020.3.19?)

@hbeni
Copy link
Contributor Author

hbeni commented Apr 20, 2024

C182 sister ticket: HHS81/c182s#587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants