Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFmpegFrameGrabber can specify the decoder name and some options #948

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fcinfo
Copy link

@fcinfo fcinfo commented Mar 28, 2018

1.FFmpegFrameGrabber can specify the decoder name and some options
2.FFmpegFrameRecorder modified some code to option encoder

@saudet
Copy link
Member

saudet commented Mar 28, 2018

Thanks! Though, before we can merge this, could you change all the tabs back into 4 whitespaces?

@saudet
Copy link
Member

saudet commented Mar 31, 2018

Also, please make sure the tests pass. They are currently failing:
https://travis-ci.org/bytedeco/javacv/pull_requests

saudet added a commit that referenced this pull request Jul 16, 2018
…CodecName` and `audioCodecName` properties (pull #948)
@saudet
Copy link
Member

saudet commented Jul 16, 2018

I've added support for videoCodecName and audioCodecName in commit a17a934. Please consider updating this pull request and making the tests pass! Thank you

@saudet saudet force-pushed the master branch 3 times, most recently from dd3b19d to d267c5f Compare June 27, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants