feat: Add support for the Joyroid Loob #545
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackspherefollower
force-pushed
the
loob-support
branch
from
bf161f5
to
a02b2d2
Compare
blackspherefollower
force-pushed
the
loob-support
branch
from
a02b2d2
to
54ac30f
Compare
blackspherefollower
force-pushed
the
loob-support
branch
from
b465bd2
to
e13303b
Compare
This change will require a fix in btleplug, as the LOOB has duplicate characteristic UUIDs and btleplug gives us the last one, not the first. See deviceplug/btleplug@4a2089b for my attempt at a fix (only tested on Windows, but passing tests on all); my concern is that there's probably a better way to collet without duplicates than using fold.
blackspherefollower
force-pushed
the
loob-support
branch
from
e13303b
to
7f9d900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will require a fix in btleplug, as the LOOB has duplicate characteristic UUIDs and btleplug gives us the last one, not the first. See deviceplug/btleplug#365 for my attempt at a fix; my concern is that there's probably a better way to collate without duplicates than using fold.