Cytopy widgets #30
Open
Cytopy widgets #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commas in the spill matrix
… entries, especially for 2d threshold gates
…hen using a threshold gate with a log transform)
…ut not for polygon gates
|
This is awesome! Thank you so much for sharing. Inspired by your work I've started creating an interactive class for editing gates, intended for use after using the With your permission I would like to integrate your work into version 3.0 as an interactive live auto gating tool, as you've built it. I also think this could make for a great little article for Bioinformatics (like an application note) or Cytometry A. If you would be interested in this I'm happy to work with you towards this. You would of course be joint first author or senior author (depending on your preference). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ross,
As promised, this is the CytoPy GUI wrapper that we discussed. I'm happy for feedback or suggestions. Since this is only a single file, I suggest to include it as a module inside CytoPy (subject to it having a separate copyright and license). Please let me know what you think!
BTW I suspect that this will only work subject to some of the modifications I made in my previous pull request (especially modifications to gate.py, gating_strategy.py, flow_plot.py)