Omnnipay v3.0 #22
Open
Omnnipay v3.0 #22
+72
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems the Poli docs are out of date and they’ve made some changes? Anyway, this fix is backwards compatible and gets the message if its there with the old name or the new one.
- also removed some old code.
strict response types - gives IDE’s better hinting and makes sure code more consitant.
POLi have moved test mode to a separate domain. This adds support for it.
- Fixes an error when null is returned instead of a string.
stead of error message
set request method as capital `POST` (burnbright#20)
|
I grant thee admin rights 👑 |
|
Might want to resurrect the CI build before merging |
|
@jedateach I've moved the CI to GH actions and fixed them up so they all run/pass. Also updated Composer deps. |
|
@jedateach you ok to merge this PR and release as v4.0.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this PR is just bumping the readme, but would be good to get this release tagged - I've been using it for a year or 2 so its pretty stable :)