Feature: IfcSweptDiskSolidPolygonal Informal Proposition #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sandbox ok a1d0aa7 |
pjanck
suggested changes
Dec 19, 2022
Comment on lines
+10
to
+11
| Then FilletRadius has to be smaller than or equal to the length of the start and end segments of the Directrix | ||
| And FilletRadius has to be smaller than or equal to the length / 2 of the inner segments of the Directrix |
There was a problem hiding this comment.
Breadcrumbs: #20 - here is another section that should be amended accordingly if we strive for maximum reusability.
| And FilletRadius = not null | ||
| And Directrix forms a closed curve | ||
|
|
||
| Then FilletRadius has to be smaller than or equal to the length of all segments of the Directrix |
There was a problem hiding this comment.
How come not length / 2, similarly to the open curve example?
There was a problem hiding this comment.
@pjanck I think you're correct. A closed curve means all segments are the "inner segments" and hence the length / 2 rule should apply. Thank you.
There are also no test cases yet for closed curve directrices.
| And FilletRadius = not null | ||
| And Directrix forms an open curve | ||
|
|
||
| Then FilletRadius has to be smaller than or equal to the length of the start and end segments of the Directrix |
There was a problem hiding this comment.
please change "shall" to "must" as per #20
| And FilletRadius = not null | ||
| And Directrix forms a closed curve | ||
|
|
||
| Then FilletRadius has to be smaller than or equal to the length of all segments of the Directrix |
There was a problem hiding this comment.
idem, change "shall" to "must" as per #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Informal Proposition that compares FilletRadius to the length of the segments of the directrix.