Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Viadotto Acerno to IFC4X3_ADD2 #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michelangelo-acca
Copy link
Collaborator

Update IFC model of Viadotto Acerno to IFC4X3_ADD2 and make it compliant with bSI Validation Service checks.

Update IFC model of Viadotto Acerno to IFC4X3_ADD2 and make it compliant with bSI Validation Service checks.
Copy link

@piotr-smolira piotr-smolira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ifc file should be updated to include the pylons and piers.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file uploaded does not have pylons and foundations. In the link from Readme all is visible.
Also when I wanted to view downloaded ifc in ACCA viewer it was not displaying anything. In Zoom Collab it worked pretty well. Can you check if these 2 files are the same?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @piotr-smolira, I am not having any problem in visualizing the file correctly.

You can have a look at it here or you can upload it on your own using our (free) cloud service, usBIM.

Let me know if you spot any mistake!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michelangelo-acca

It appears that indeed the model is complete. It might be shortcoming of viewers.
This is how it looks in BIM Zoom Collab:
image

This is Open IFC viewer:
image

This is how it looks when I uploaded file to cloud.usBIM and view in a viewer:
image

This is how it looks in desktop usBIM viewer:
image

From your link:
image

I wonder if it something with ACCA setting or some other reason. Because from the link it just works perfectly fine. Only viewer that displays everything and quite fast.

In solibri it doesn't open.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IfcOpenShell (latest of the v0.8 branch) renders the model like this:

afbeelding

I'm not saying IfcOpenShell is doing the correct thing, things are under heavy development still, but it seems the model is complete.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting a similar image in IFC Viewer from RDF, including the alignments in the other direction. Also there seem to be three IfcSurfaceFeatures that are flying around in the file.
image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterrdf It looks fine in rdf viewer.
@aothms could you pass me BBIM with IfcOpenShell 0.8? I try compiling but as a complete newb and no knowledge of C++ whatsoever I failed and I would love to try it. I'm currently sitting on latest release of 0.7.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pass me BBIM with IfcOpenShell 0.8

I doesn't exist yet, but I think we're close.

If you want to try ahead of the pack where it fails you can always replace the ifcopenshell folder in your bbim installation with IfcOpenBot/IfcOpenShell@3230854#commitcomment-140952402 and see where it fails. I'll be around to advise.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterrdf @aothms Glad to see the model is opening correctly in different viewers!

Regarding the IfcSurfaceFeatures, they do not have ContainedInStructure relationship, as it is now allowed by the schema, but they do have the AdheresToElement one...maybe this is the problem?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thomas! I managed to insert package in bbim.
I wonder if I did it correctly: I downloaded the latest zip release; unzipped; replace ifcopenshell site package; zipped; installed bbim-addon. It seems it works but I wonder if it is proper way.

To the subject: The file fails to load. I wonder what options I need to pick to have it open. This looks when loading by default settings:
image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piotr-smolira shall we move that discussion to somewhere in the ifcopenshell repo as it's not relevant to the people here and we can benefit from @Andrej730 and @Moult's expertise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants