Update IfcVoidingFeature.md #799
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of holes in buildings can exceed the number of openings. I suggest adding the use of Reference Geometry concept for IfcVoidingFeature in the same way as IfcOpeningElement. An IFC file with Reference Geometry for IfcVoidingFeature will make the work of viewers easier. I also suggest using Quantity Sets concept for IfcVoidingFeature. Holes reduce the weight of building structures while increasing the surface area of the structure. It will be useful to get the design characteristics of holes for consideration in the building model. I note that these changes will be useful in IFC4_ADD2_TC1 - 4.0.2.1
|
It would be good to know if the current situation is intentional or not. I can imagine that for example holes for screws increase the triangle count dramatically more than window openings do, while maybe not as significant for visual display or quantities. But it could also simply be an oversight due to abstractions being introduced into the inheritance hierarchy. Maybe @TLiebich has some recollection of this? On a technical note, this only the documentation change, the actual association of a concept template to an entity needs to be defined in UML, but we can apply that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of holes in buildings can exceed the number of openings. I suggest adding the use of Reference Geometry concept for IfcVoidingFeature in the same way as IfcOpeningElement. An IFC file with Reference Geometry for IfcVoidingFeature will make the work of viewers easier.
I also suggest using Quantity Sets concept for IfcVoidingFeature. Holes reduce the weight of building structures while increasing the surface area of the structure. It will be useful to get the design characteristics of holes for consideration in the building model.
I note that these changes will be useful in IFC4_ADD2_TC1 - 4.0.2.1