Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IfcLinearPlacement attributes description #775

Merged
merged 4 commits into from
May 16, 2024
Merged

IfcLinearPlacement attributes description #775

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f73dcc
add attributes description
evandroAlfieri Jan 25, 2024
c4a780e
Merge branch 'buildingSMART:master' into IF_IfcLinearPlacement-attrib…
evandroAlfieri Jan 30, 2024
b6f0a5a
Update docs/schemas/resource/IfcGeometricConstraintResource/Entities/…
evandroAlfieri May 16, 2024
133a12b
Update docs/schemas/resource/IfcGeometricConstraintResource/Entities/…
evandroAlfieri May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../schemas/resource/IfcGeometricConstraintResource/Entities/IfcLinearPlacement.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ _IfcLinearPlacement_ provides a specialization of _IfcObjectPlacement_ in which
## Attributes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, I've encapsualated them into the suggestions below:

Re RelativePlacement

Resemblance of equivalent attributes on other placement types (At least the word placement should probably be used)

grid: Placement of the object coordinate system defined by the intersection of two grid axes.

local: Geometric placement that defines the transformation from the related coordinate system into the relating. The placement can be either 2D or 3D, depending on the dimension count of the coordinate system.

Re CartesianPosition

Reverse the order of the statements

Make it unambiguous that this is only the equivalent of the relative part, not the including the absolute transform.

Mention importing applications can use it. Metnion optional.

Re 2d / 3d

For IfcPointOnCurve we have "The coordinate space dimensionality of the point is that of the basis curve.". That is very clear and elegant. IfcPointByDistanceExpr is also has dimensionality derived from its basis (IfcPointDim), so can be 2d. When we say linear placement is by definition 3d I don't find it very elegant (did nobody consider 2d objects contexts along a horizontal alignment?). But it's in the entity text and the cartesian fallback is also 3d specifically, so no point in arguing this. but if a placement along a 2d curve is 3d in nature I think it deserves some additional emphasis [also created #846].


### RelativePlacement

Placement that provides location and orientation confined to the context of a curve. Linear placement is 3D in nature even in case of a 2D basis curve.

### CartesianPosition

Optional fallback for the `RelativePlacement` attribute, which may be used by importing applications that do not support linear placement.