Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some tests to increase coverage #263

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

giuseppeverduciALMA
Copy link
Contributor

I added four test cases to increase the coverage.
Two tests related to classifications and two tests related to prohibited specifications (applicability).

Giuseppe Verduci and others added 2 commits March 29, 2024 16:46
Minor fix in IDS script syntax and adjusted script:
- minor title fix
- removed redundant "requirements:" lines
@CBenghi CBenghi self-requested a review March 29, 2024 17:24
Copy link
Contributor

@CBenghi CBenghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giuseppeverduciALMA,
I've made a couple of minor fixes to sync the titles, but otherwise all good and useful.

@CBenghi CBenghi linked an issue Mar 29, 2024 that may be closed by this pull request
@CBenghi
Copy link
Contributor

CBenghi commented Mar 29, 2024

@berlotti,
is it ok if I ping you to merge once an issue/PR couple is in place?

@CBenghi CBenghi added this to the 1.0 milestone Mar 29, 2024
@berlotti berlotti merged commit 57f5189 into buildingSMART:development Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test case coverage
3 participants