Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use integer instead of decimal number as simple value #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pasi-paasiala
Copy link
Contributor

#126

The required type is integer

@aothms aothms requested a review from Moult February 2, 2023 07:50
@berlotti
Copy link
Member

can you review @CBenghi and @Moult ?

@CBenghi
Copy link
Contributor

CBenghi commented May 10, 2023

Hi @berlotti, I don't have permissions on the repository to review.

@CBenghi
Copy link
Contributor

CBenghi commented May 31, 2023

The PR proposes a solution to #126, but the file changed is programmatically generated, so fixing it here would not make the difference at the next regeneration.

I suggest we close this PR, as the solution of #126 will provide a change to the auditing tool that would catch the issue ahead of 1.0.

@pasi-paasiala do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants