New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about pagination #230
base: release_3_0
Are you sure you want to change the base?
Conversation
@jasollien is it common to specify |
I've seen many API using headers to add some context to the query (not with odata though). A dot in a header name seems to be forbidden (https://tools.ietf.org/html/rfc7230#section-3.2.6) |
I'm also not a huge fan of using headers to transport data myself, since it makes client implementations harder. So maybe we should keep the headers optional? Also I think we should prepend the headers with a |
x- for custom header has been deprecated (https://tools.ietf.org/html/rfc6648 and https://stackoverflow.com/a/3561399). I think a prefix to avoid any name conflict could be great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a bit more information in the commit message. Is this related to some issue? Content of the change seems fine.
This is a pretty old PR, but still an important one😀 We've just discussed this in the call, and it looks like there's more work to do. The basic facts right now are:
-> We need to spend a bit of time on that issue. In the discussion, we felt that we probably have to modify all the responses for list results to return wrapping elements, but this is a bit of work. |
No description provided.