react-base: Minor fix and improvement to ForceBuildModal fields #7571
+1,269
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
approved these changes
May 15, 2024
p12tic
force-pushed
the
react-base/force-build-fields-fixes
branch
from
fea991d
to
baddede
Compare
|
@tdesveaux Does this PR really not need a newsfragment? It does fix something. |
You're right, I can't remember why I thought differently. |
tdesveaux
force-pushed
the
react-base/force-build-fields-fixes
branch
from
baddede
to
4f73e13
Compare
tdesveaux
commented
May 17, 2024
www/react-base/src/components/ForceBuildModal/Fields/FieldInt.tsx
Outdated
Show resolved
Hide resolved
tdesveaux
force-pushed
the
react-base/force-build-fields-fixes
branch
2 times, most recently
from
642fa9c
to
30dcdd9
Compare
'Form.Control' with 'multiple' prop expect 'value' to be an array of values.
tdesveaux
force-pushed
the
react-base/force-build-fields-fixes
branch
from
30dcdd9
to
a4eda76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly fix
FieldChoiceStringwithmultiple.Biggest change was to untype the value stored by
ForceBuildfieldsStateas storing everything as string would be awkward in some places and I don't think it brought much to type it.Contributor Checklist:
newsfragmentsdirectory (and read theREADME.txtin that directory)