Make init/de-init less intrusive #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grembo
force-pushed
the
less-intrusive-init
branch
from
8929e99
to
2e6aafe
Compare
This adds the flag "-m" to be minimally intrusive. Also allows de-init to use "-p pf_file" to specify the firewall rulesets (this way it's symmetrical to init). Rename "-f pf_file" to "-p pf_file" in init (as "-f" was already taken in de-init), but keep "-f" as an alias for the time being. Add flag "-s" to init (do not alter syslogd configuration). Some minor cleanup of variable names while there. Fixes bsdpot#85
grembo
force-pushed
the
less-intrusive-init
branch
from
2e6aafe
to
ff888e4
Compare
dblane-digicatapult
added a commit
to digicatapult/pot
that referenced
this pull request
Feb 20, 2024
* Make init/de-init less intrusive (bsdpot#284) This adds the flag "-m" to be minimally intrusive. Also allows de-init to use "-p pf_file" to specify the firewall rulesets (this way it's symmetrical to init). Rename "-f pf_file" to "-p pf_file" in init (as "-f" was already taken in de-init), but keep "-f" as an alias for the time being. Add flag "-s" to init (do not alter syslogd configuration). Some minor cleanup of variable names while there. Fixes bsdpot#85 * Find bridge interfaces by interface group (bsdpot#282) This allows users to give their bridges custom names. We might make use of this as well in the future (think $POT_BRIDGE_NAME). * New global config to isolate vnet pots (bsdpot#283) This new global setting called `POT_ISOLATE_VNET_POTS` sets bridge member epaira interfaces to be private, preventing them from forwarding traffic to each other. This helps with overall security, but (primarily) makes sure that pots in larger nomad clusters don't talk to each other using direct communication instead of published (natted) endpoints. This could be a more fine-grained per pot setting in the future, in our setups we only ever needed a global setting decided by the infrastructure operator (so, e.g., in the nomad cluster, everything uses this setting, whereas in the more static part forming the infrastructure the nomad cluster relies on, direct communication between pots is wanted) and changing it per pot would be a disadvantage - hence this implementation. * Fix typo in set-status.sh * Prepare 0.16.0 (bsdpot#285) --------- Co-authored-by: grembo <freebsd@grem.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the flag "-m" to be minimally intrusive. Also allows de-init to use "-p pf_file" to specify the firewall rulesets (this way it's symmetrical to init).
Rename "-f pf_file" to "-p pf_file" in init (as "-f" was already taken in de-init), but keep "-f" as an alias for the time being.
Add flag "-s" to init (do not alter syslogd configuration).
Some minor cleanup of variable names while there.
Fixes #85