libioc should support iocage's template jails #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libiocage does not right now support iocage's template jails. This commit introduces the following changes: 1) Make sure that libiocage is able to create jails from iocage's template jails 2) Libiocage is able to list iocage's template jails 3) A bug fix in JailConfig where we try to fetch the rc_conf file when the jail does not exist 4) Bug fixes in special properties ( DefaultRouter, Resolver ) where a bug in libiocage did not anticipate that objects of these special properties could be sent as as set value
skarekrow
suggested changes
Nov 18, 2018
| @@ -81,7 +84,7 @@ def __iter__( | |||
| self | |||
| ) -> typing.Generator['iocage.Resource.Resource', None, None]: | |||
| """Return an iterator over the child datasets.""" | |||
| if self.namespace is None: | |||
There was a problem hiding this comment.
Perhaps we make this an OR with the below addition?
There was a problem hiding this comment.
I am not sure if I followed you correctly. Are you suggesting self.namespace is None or not self.namespace ?
There was a problem hiding this comment.
Yep! Stefan probably has a specific use for None.
There was a problem hiding this comment.
Oh, I was not aware of that. not self.namespace should normally cover the general negation scenario but if we have a specific use case, then that needs to be followed through. Let's confirm this ? @gronke could you confirm this please ?
gronke
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libiocage does not right now support iocage's template jails. This commit introduces the following changes: