Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Resource namespace #577

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor Resource namespace #577

wants to merge 2 commits into from

Conversation

gronke
Copy link
Member

@gronke gronke commented Nov 10, 2018

  • groups Resource in a module directory

@gronke gronke added the chore label Nov 10, 2018
Copy link
Collaborator

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is our hierarchy so deep & complicated to begin with?

@@ -413,3 +413,16 @@ def destroy(
def save(self) -> None:
"""Save changes to the default configuration."""
self._write_config(self.config.user_data)


iocage.hook_module(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a python thing, or a (lib)iocage thing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A local workaround for ugly Python module names. Makes them callable and act like classes with the same names.

@urosgruber
Copy link
Contributor

Is this done and can be tested or some work still required?

@igalic
Copy link
Collaborator

igalic commented Nov 29, 2018

Is this done and can be tested or some work still required?

@urosgruber unfortunately, @gronke has been burried under real life, paid work, so this hasn't been touched since, and i'm fairly certain it needs some more work before it can be tested.

Unless you feel particularly adventures 😅

@urosgruber
Copy link
Contributor

@igalic thanks for the update. Anyone knows how long will it take for this project to continue with it's pace. I notice it was a bit quiet here lately. I would help here but I'm very rookie around Python so I doubt there is anything I can do except testing.

@gronke
Copy link
Member Author

gronke commented Nov 30, 2018

As @igalic already has pointed out I've put focus on paid work, so that I was entirely booked in the past two month. This will continue in December and January and is necessary to secure my independence developing the lib, as done the year before. I am not sleeping, just breathing.

The community around libiocage is small, but all the feedback, reviews and contributions motivate me to continue with the same quality objectives in mind. Speaking up here on GitHub is now more important than ever before - please stay alerted on the https://github.com/iocage/iocage/tree/v2 branch as well, because this is where shit will hit the fan.

@urosgruber
Copy link
Contributor

@gronke really appreciate your hard work and quick turnarounds.

@igalic
Copy link
Collaborator

igalic commented Jan 5, 2019

i still really like this work!
it'll need a rebase now, however, aaaaand a documentation update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants