Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic job positions parsing #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

StanBoyet
Copy link
Contributor

@StanBoyet StanBoyet commented Oct 14, 2018

This PR addresses the issue #88 .

The idea of the PR is to have a 1st version to display the positions on the website.
I feel like having an external link to a Github Repo is not enough of a proof of concept to learn anything from it and see if we can have an impact on this area.

On the other hand, I think that creating these markdowns files for each job is a good middle-ground for companies, as it's both easy and secured by the PR which is reviewed by the association.

This PR addresses this issue and tries to provide a first proof of concept to have these positions on the website.

This is a WIP for the moment, the view is "just" a dump of the parsed markdown in HTML. It works and markdown is being parsed, but it looks awful.

On the top of my head, here's what's missing:

  • An index of all the position names at the top of the page
  • Custom markdown renderer to force the markdown # Title to be h3 instead of h1 and so one for the next title levels. Otherwise, we end up with multiple h1 and it breaks the architecture
  • An accordion for each position. When you click on the name, you scroll and open this one, closes the others. This should work fine with anchor, and would be ideal to link positions with the URL

Bonus:

  • Use what is described at the previous point to share a specific position. Could be fairly easy IMO

Edit: Add screenshot
image

@StanBoyet StanBoyet added the wip Work In Progress label Oct 14, 2018
Copy link
Member

@borisrorsvort borisrorsvort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accordeon are not meant to display huge amount of texts. So I’d go more with a index / show pages and a «return to jobs» link or something.

@StanBoyet
Copy link
Contributor Author

@borisrorsvort I see what you mean. IMO though, I see the postings as "cards" and not really wall of texts, but it's true some of them are.

If we go this way, then we could use the dynamic pages from middleman: https://middlemanapp.com/advanced/dynamic-pages/

I'm a bit torn as to how to characterize this content, thus if it needs dedicated resources.

@otagi What do you think?

@borisrorsvort
Copy link
Member

How how /jobs/:id ? ;)

@borisrorsvort
Copy link
Member

@StanBoyet any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants