fix: Check for event.preventDefault() before setting state
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
approved these changes
Sep 27, 2022
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
brophdawg11
reviewed
Sep 29, 2022
| onChange?.(event); | ||
| if (!event.defaultPrevented) { | ||
| setDirty(true); | ||
| setValue(event.target.value); |
There was a problem hiding this comment.
I'm not sure this is what we want if the change event is prevented - since that happens after the input value has been set in the DOM (at least for text and similar inputs - would need to look closer on radio/checkbox). If we don't set the controlled value we can get into weird UI states:
Users can use onKeyDown currently to prevent typed characters.
I've been thinking for a while too that I'd like to take a stab at making this entire library uncontrolled and just always use inputEl.value, which would remove this setValue entirely. I think that's feasible and would get rid of the useState so might have the worlds tiniest perf improvement 🎻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user prevents a form input's default behavior, the
onChangeingetInputAttrsshouldn't set state internally. To fix this I call the user's handler first, check forevent.defaultPreventedand then continue with the internal event handler.