Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial preact implementation #19

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

initial preact implementation #19

wants to merge 10 commits into from

Conversation

jacob-ebey
Copy link
Collaborator

No description provided.

@brophdawg11 brophdawg11 self-assigned this Sep 8, 2022
<Suspense
fallback={<p id="lazy-error">Loading error...</p>}
key={`error-${location.key}`}
>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacob-ebey So this is a total hack but solves the issue for the time being 🤷‍♂️. I made an issue in the Projects view to look into solving the never-resolving promise issue to unblock this

@brophdawg11
Copy link
Owner

Unsure what's going on with the CI tests - they seem ok locally but preact tests are flakey in CI. Will look into it more another time

@IshanKBG
Copy link

IshanKBG commented Jan 21, 2023

Any update on this PR?

Really excited to see preact support

@brophdawg11
Copy link
Owner

@IshanKBG I believe we were waiting on a suspense fix in preact so defer would work right, but there's probably no reason that needs to hold up an initial merge here. I'll see if I can find some time this week or next to maybe remove defer/Await from this initial PR and get a working version out and then we can focus on those in a separate PR

@IshanKBG
Copy link

IshanKBG commented Jan 25, 2023

@brophdawg11
Oh nice
Thanks for notifying me

@nicksrandall
Copy link

I'd love to use this if possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants