-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial preact implementation #19
base: main
Are you sure you want to change the base?
Conversation
<Suspense | ||
fallback={<p id="lazy-error">Loading error...</p>} | ||
key={`error-${location.key}`} | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacob-ebey So this is a total hack but solves the issue for the time being 🤷♂️. I made an issue in the Projects
view to look into solving the never-resolving promise issue to unblock this
Unsure what's going on with the CI tests - they seem ok locally but preact tests are flakey in CI. Will look into it more another time |
Any update on this PR? Really excited to see preact support |
@IshanKBG I believe we were waiting on a suspense fix in preact so defer would work right, but there's probably no reason that needs to hold up an initial merge here. I'll see if I can find some time this week or next to maybe remove |
@brophdawg11 |
I'd love to use this if possible! |
No description provided.