Skip to content

Commit

Permalink
refactor: switch to internal __createFactory function
Browse files Browse the repository at this point in the history
to avoid using the deprecated React.createFactory function

(and update .size-snapshot.json)

resolves acdlite#806
  • Loading branch information
brodybits committed Feb 3, 2021
1 parent 3d6131a commit da77244
Show file tree
Hide file tree
Showing 20 changed files with 48 additions and 30 deletions.
18 changes: 9 additions & 9 deletions .size-snapshot.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{
"lib/packages/recompose/dist/Recompose.umd.js": {
"bundled": 46425,
"minified": 16484,
"gzipped": 4625
"bundled": 46573,
"minified": 16272,
"gzipped": 4626
},
"lib/packages/recompose/dist/Recompose.min.js": {
"bundled": 42863,
"minified": 15204,
"gzipped": 4194
"bundled": 43011,
"minified": 14992,
"gzipped": 4185
},
"lib/packages/recompose/dist/Recompose.esm.js": {
"bundled": 32428,
"minified": 15083,
"gzipped": 3550,
"bundled": 32663,
"minified": 15157,
"gzipped": 3560,
"treeshaked": {
"rollup": {
"code": 310,
Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/__tests__/hoistStatics-test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, { createFactory } from 'react'
import React from 'react'
import { mount } from 'enzyme'
import sinon from 'sinon'
import createFactory from '../createFactory'
import { hoistStatics, mapProps } from '../'

test('copies non-React static properties from base component to new component', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/branch.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
9 changes: 9 additions & 0 deletions src/packages/recompose/createFactory.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { createElement } from 'react'

// NOTE: This is intended to be an internal utility for now, may be
// unit-tested, documented, and exported by the API in the future.
export default function __createFactory(c) {
// as described in:
// - https://reactjs.org/blog/2020/02/26/react-v16.13.0.html
return createElement.bind(null, c)
}
2 changes: 1 addition & 1 deletion src/packages/recompose/defaultProps.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/flattenProp.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
6 changes: 3 additions & 3 deletions src/packages/recompose/fromRenderProps.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand All @@ -7,8 +7,8 @@ const fromRenderProps = (
propsMapper,
renderPropName = 'children'
) => BaseComponent => {
const baseFactory = React.createFactory(BaseComponent)
const renderPropsFactory = React.createFactory(RenderPropsComponent)
const baseFactory = createFactory(BaseComponent)
const renderPropsFactory = createFactory(RenderPropsComponent)

const FromRenderProps = ownerProps =>
renderPropsFactory({
Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/getContext.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/lifecycle.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint-disable no-console */
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/mapProps.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/mapPropsStream.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createFactory } from 'react'
import $$observable from 'symbol-observable'
import createFactory from './createFactory'
import { componentFromStreamWithConfig } from './componentFromStream'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'
Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/nest.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './createFactory'
import getDisplayName from './getDisplayName'

const nest = (...Components) => {
Expand Down
2 changes: 1 addition & 1 deletion src/packages/recompose/renderComponent.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createFactory } from 'react'
import createFactory from './createFactory'
import wrapDisplayName from './wrapDisplayName'

const renderComponent = Component => _ => {
Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/shouldUpdate.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/withContext.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/withHandlers.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint-disable no-console */
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'
import mapValues from './utils/mapValues'
Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/withPropsOnChange.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import { polyfill } from 'react-lifecycles-compat'
import createFactory from './createFactory'
import pick from './utils/pick'
import shallowEqual from './shallowEqual'
import setDisplayName from './setDisplayName'
Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/withReducer.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand Down
5 changes: 3 additions & 2 deletions src/packages/recompose/withState.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import __createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'

Expand All @@ -7,7 +8,7 @@ const withState = (
stateUpdaterName,
initialState
) => BaseComponent => {
const factory = createFactory(BaseComponent)
const factory = __createFactory(BaseComponent)
class WithState extends Component {
state = {
stateValue:
Expand Down
3 changes: 2 additions & 1 deletion src/packages/recompose/withStateHandlers.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFactory, Component } from 'react'
import { Component } from 'react'
import createFactory from './createFactory'
import setDisplayName from './setDisplayName'
import wrapDisplayName from './wrapDisplayName'
import mapValues from './utils/mapValues'
Expand Down

0 comments on commit da77244

Please sign in to comment.