feat(arm): AppServicePythonVersion - 82 check the 'python version' is the latest, if used to run the web app #6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return "properties/siteConfig/pythonVersion" | ||
|
|
||
| def get_expected_value(self) -> str: | ||
| return "3.4" |
There was a problem hiding this comment.
@tsmithv11 Should we use 3.12 here?
There was a problem hiding this comment.
We should accept 3.9-3.12 here (all not EOL or close to EOL). The TF policy is on a deprecated resource that can only go up to 3.4, but this one appears to be able to go up to 3.12.
There was a problem hiding this comment.
So, @tsmithv11 correct me if I'm wrong, but it can be a Py check but a Yaml check, right?
There was a problem hiding this comment.
@ChanochShayner this is a single attribute inside a single resource, so a Python check will probably be better so we can have auto-fixes for it.
RachelBorzi
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
reviewed
May 20, 2024
Comment on lines
+22
to
+23
| def get_expected_value(self) -> str: | ||
| return "3.10" |
There was a problem hiding this comment.
Suggested change
| def get_expected_value(self) -> str: | |
| return "3.10" | |
| def get_expected_values(self) -> List[Any]: | |
| return ["3.9", "3.10", "3.11", "3.12"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
feat(arm): add CKV_AZURE_82 to ensure that 'Python version' is the latest, if used to run the web app
Description
I added a test that verifies whether the python version is latest if used to run the web app
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: