feat(arm): AzureDefenderOStorage #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 61b10d6.
…ureDefenderOnStorage1
shoshiGit
changed the title
shoshiGit
changed the title
| resourceType = properties.get("resourceType") | ||
| return ( | ||
| CheckResult.PASSED | ||
| if resourceType != "StorageAccounts" or tier == "Standard" |
There was a problem hiding this comment.
the resource type here is not StorageAccounts but Microsoft.Security/pricings
ChanochShayner
requested changes
May 19, 2024
| resourceType = properties.get("resourceType", "") | ||
| return ( | ||
| CheckResult.PASSED | ||
| if resourceType != "Microsoft.Security/pricings" or tier == "Standard" |
There was a problem hiding this comment.
ChanochShayner
approved these changes
May 20, 2024
| resourceType = properties.get("resourceType", "") | ||
| return ( | ||
| CheckResult.PASSED | ||
| if resourceType != "Microsoft.Security/pricings" or pricingTier == "Standard" |
There was a problem hiding this comment.
You can remove the if resourceType != "Microsoft.Security/pricings" - in ARM it will always be this type.
(Just for terraform it can be other types as well)
tsmithv11
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
We converted the check AzureDefenderOnstorage from TERRAFORM language to the ARM language so that it also works on resources that are defined in the ARM language/
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Ensure that Azure Defender is set to On for Storage.
Fix
To address the issue, ensure that the Azure Defender setting is configured to On for the relevant storage resources. This can typically be done through the Azure Portal by navigating to the Security Center settings for the storage account and enabling Azure Defender.
Checklist: