Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): ArmStorageSyncPublicAccessDisabled #6268

Conversation

esterKoren
Copy link
Contributor

@esterKoren esterKoren commented May 7, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

We converted the check StorageSyncPublicAccessDisabled from TEerraform language to ARM so that it also works on resources that are defined in ARM.

Fixes # (issue)

Description

Ensure that Azure File Sync disables public network access

Fix

To address the issue, ensure that the Azure File Sync service is
configured to disable public network access. This can typically be done
by adjusting the configuration settings for Azure File Sync either
through the Azure Portal or using Azure CLI/PowerShell commands.
Specifically, you need to set the publicNetworkAccess property to Disabled.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@esterKoren esterKoren changed the title Arm storage sync public access disabled feat(arm): ArmStorageSyncPublicAccessDisabled May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant