Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IMDS named tags & ExtendedMeta #955

Merged
merged 4 commits into from Aug 14, 2023
Merged

Add IMDS named tags & ExtendedMeta #955

merged 4 commits into from Aug 14, 2023

Conversation

ulidtko
Copy link
Contributor

@ulidtko ulidtko commented Aug 13, 2023

Hi @endgame β€” submitting a little patch that fixes #954.

Both discussed items implemented. Compiles & tests pass. Please review πŸ™

Copy link
Collaborator

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an entry to lib/amazonka/CHANGELOG.md.

Note: I'll be away and uncontactable for a couple of weeks from tomorrow.

lib/amazonka/src/Amazonka/EC2/Metadata.hs Outdated Show resolved Hide resolved
@ulidtko
Copy link
Contributor Author

ulidtko commented Aug 14, 2023

@endgame done.

lib/amazonka/CHANGELOG.md Outdated Show resolved Hide resolved
@endgame endgame merged commit a8f1d24 into brendanhay:main Aug 14, 2023
3 of 5 checks passed
@ulidtko
Copy link
Contributor Author

ulidtko commented Aug 14, 2023

Thanks!

@ulidtko ulidtko deleted the fix/IMDS-tags branch August 14, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to fetch values of named Tags in IMDS Instance Metadata
2 participants